concourse-worker: add watchdog process #5
Conversation
sdurrheimer
force-pushed
the
sd-concourse_worker_watchdog
branch
6 times, most recently
from
ec468d4 to
26a3bcf
Compare
sdurrheimer
force-pushed
the
sd-concourse_worker_watchdog
branch
3 times, most recently
from
03ea310 to
0f13ff4
Compare
sdurrheimer
force-pushed
the
sd-concourse_worker_watchdog
branch
from
0f13ff4 to
663e615
Compare
|
Currently blocked by concourse/concourse#5742 |
Workaround of #5 This commit will need to be revert when real watchdog will be unblocked
| owner: root | ||
| force: yes | ||
| become: yes | ||
| become_user: root | ||
| with_items: |
There was a problem hiding this comment.
Same reason as #5 (comment)
| @@ -4,6 +4,8 @@ | |||
| Description=concourse-worker | |||
| Requires=network-online.target | |||
| After=network-online.target | |||
| Wants=concourse-worker-watchdog.service | |||
There was a problem hiding this comment.
no concourse-worker-watchdog.service anymore ? should be removed ?
There was a problem hiding this comment.
We will wait for concourse to fix the issue.
Right now the PR reflect the second implementation where the watchdog is a sub-process in the background of the main concourse-worker process (`NotifyAccess=main`) but I prefer my first implementation where the watchdog was a separated process (`NotifyAccess=all`)
There was a problem hiding this comment.
currently it is a mix of both ? Sub-process is used but ext service is referenced here.
Just a reminder note, for ext service this part will be missing: https://github.com/cycloidio/ansible-concourse/pull/7/files#diff-2f8071c99c715eb05ff6fabd9fed7dd5R15
There was a problem hiding this comment.
currently it is a mix of both ? Sub-process is used but ext service is referenced here.
Yes, I did a bunch of tests for different implementations, I must have missed some old references ^^
Just a reminder note, for ext service this part will be missing: https://github.com/cycloidio/ansible-concourse/pull/7/files#diff-2f8071c99c715eb05ff6fabd9fed7dd5R15
Good catch, I will update this PR as soon as possible to represent the ideal setup if Concourse will ever fix the issue blocking it.
Workaround of #5 This commit will need to be revert when real watchdog will be unblocked
Workaround of #5 This commit will need to be revert when real watchdog will be unblocked
Workaround of #5 This commit will need to be revert when real watchdog will be unblocked
No description provided.