Implement buffering

src/WritableXliffDictionary.php

@@ -57,10 +57,10 @@
         }
 
         if (!file_exists($filename)) {
             if ($sourceLanguage) {
                 $this->setSourceLanguage($sourceLanguage);
             }
             if ($targetLanguage) {
                 $this->setTargetLanguage($targetLanguage);
             }
             $this->markChanged();
@@ -117,6 +117,8 @@
         if ($this->buffering) {
             throw new RuntimeException('Already buffering.');
         }
+
+        $this->buffering = true;
     }
 
     /**

tests/WritableXliffDictionaryTest.php

@@ -27,11 +27,11 @@ public function testInstantiation(): void
         self::assertSame('de', $dictionary->getTargetLanguage());
         self::assertSame(
             ['test-string-with-only-source', 'test-string-with-source-and-target'],
-            iterator_to_array($dictionary->keys())
+            iterator_to_array($dictionary->keys()),
         );
         self::assertInstanceOf(
             XliffTranslationValue::class,
-            $value = $dictionary->get('test-string-with-only-source')
+            $value = $dictionary->get('test-string-with-only-source'),
         );
         self::assertSame('test-string-with-only-source', $value->getKey());
         self::assertSame('The source value', $value->getSource());
@@ -41,7 +41,7 @@ public function testInstantiation(): void
 
         self::assertInstanceOf(
             XliffTranslationValue::class,
-            $value = $dictionary->get('test-string-with-source-and-target')
+            $value = $dictionary->get('test-string-with-source-and-target'),
         );
         self::assertSame('test-string-with-source-and-target', $value->getKey());
         self::assertSame('The source value', $value->getSource());
@@ -133,4 +133,23 @@ public function testWritingThrowsForUnknown(): void
 
         $dictionary->getWritable('unknown-key');
     }
+
+    public function testBuffering(): void
+    {
+        $dictionary = new WritableXliffDictionary($this->getTempFile());
+        $dictionary->beginBuffering();
+        self::assertTrue($dictionary->isBuffering());
+    }
+
+    public function commitBuffering(): void
+    {
+        $dictionary = new WritableXliffDictionary($this->getTempFile());
+        $dictionary->beginBuffering();
+        self::assertTrue($dictionary->isBuffering());
+
+        $dictionary->add('test');
+        $dictionary->commitBuffer();
+
+        self::assertFalse($dictionary->isBuffering());
+    }
 }