Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference error document undefined #2623

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mstrofbass
Copy link
Collaborator

This is a possible, temporary solution for the defect discussed in #2583.

Simply checking if document exists should clear up the error.

@raineorshine raineorshine changed the title DRAFT: Reference error document undefined Reference error document undefined Nov 25, 2024
Copy link
Contributor

@raineorshine raineorshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPDATE: I see this may no longer be needed if #2624 fixes the issue.

Yes, I suppose that hiding the issue is better than having to revert the previous test changes that introduces the async issue.

Could you add a console.warn when document is undefined? That will avoid entirely brushing the problem under the rug and allow us to notice if it is still an issue in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants