Don't cancel gesture if touch is > 100 pixels away #2607
Conversation
| const importText = ` | ||
| - ${cursor}` | ||
|
|
||
| await page.emulate(iPhone) |
There was a problem hiding this comment.
@raineorshine @trevinhofmann I cannot for the life of me get puppeteer to simulate a selection while emulating a mobile browser. I'll give it another try on Monday, but please let me know if you have any experience getting it to work.
There was a problem hiding this comment.
Thanks for trying! If it's difficult/impossible I'm okay skimping on test coverage here.
There was a problem hiding this comment.
Did you try creating a selection with touch events, or by directly accessing the browser selection API?
There was a problem hiding this comment.
I did try directly accessing the browser selection API, and found that it wouldn't hold onto the selection once it left the page.evaluate block. That might be worth another try, but I didn't have much luck the first time.
As for creating the selection with touch events, I tried to use a physical device to figure out how that would work, and it seemed like the only way to get a selection was to tap and then use the tooltip menu to "Select All". I don't think the tooltip menu appears in the Puppeteer emulator. If you know another, more reliable way to tap to create a a selection, please do let me know.
There was a problem hiding this comment.
A double tap selects the word under the touch. I imagine you will run into the same issue though in which the selection is lost after the page.evaluate.
We will have to rely on manual testing for this one 👍
#1705
Get the bounding client rect for the current selection (if applicable) and only abandon a gesture if the
touchstartcoordinates are within a box that extends 100 pixels out from the client rect.