Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement custom input field #88

Closed
wants to merge 51 commits into from
Closed

Implement custom input field #88

wants to merge 51 commits into from

Conversation

yrjarv
Copy link
Member

@yrjarv yrjarv commented Oct 30, 2024

Resolves #84
I had to branch from development and not main due to some changes to the database calls on the membership page. Hope that is ok.
The custom field is only used on the membership page, but the custom component is in the shared components directory so it can be used anywhere.
I am not sure why there are 48 commits on this PR.

yrjarv and others added 30 commits September 20, 2024 11:12
@yrjarv
Replace "Profile" with first section of user name
1948d7a 
Related to cybernetisk#42
We risk issues when name is long or if the user has multiple first names ("Per Ole Hansen" will be shown as "Per" and not "Per Ole")
@yrjarv
Allow width of LoginButton to be automatic
9cfb39e 
Remove hard width limit for the LoginButton text, allow the Grid containing LoginButton to shrink to the appropriate size for the length of the text inside LoginButton
@yrjarv
Enable shortening of first name in profile button
3ac806f
@EricSvebakk
Added force-graph logic
9056baf
@yrjarv
Reduce max first name length in profile button to 15
4e18084
@yrjarv
Reload page when user info is updated
216dbd2 
Awaits prismaRequest, then reloads the entire page. This 1) confirms to the user that something happened, and 2) updates AppBar to ensure the first name is always correct.
I could not get router.refresh() to work, so window.location.reload() is the best replacement I could find.
@yrjarv
Replace hyphens in first name with non-breaking hyphen
0b9a317
@EricSvebakk
Merge pull request cybernetisk#44 from yrjarv/main
cee4b41 
First name instead of 'Profile' in right corner of header
@Sebbben
Renamed some directories to take advantage of nexts routing for more …
0d154f5 
…usable url paths
@Sebbben
visual queue when registering user
0b33808
@yrjarv
Manually replaces "About CYB" with "About" on mobile
99e5190
@pvk05
fixed response from sendMail function to send correct feedback when f…
3f547cf 
…ailing
@pvk05
checks if email includes "@" before registering user
8a3d2de
@Sebbben
added loading indicator to singin page as well
ea38e61
@pvk05
moved register response to a snackbar for better visual feedback
221a968
@EricSvebakk
Audited mui version
2c516d4
@EricSvebakk
Update development.yml
15dc90b
@EricSvebakk
Merge branch 'feature-recruitment-graph' into development
0972970
@EricSvebakk
Merge branch 'development'
eb8b2f2
@pvk05
Merge branch 'cybernetisk:main' into fixRegisterUserResponse
131cc76
@EricSvebakk
Merge pull request cybernetisk#58 from yrjarv/shorter-about-mobile
4f7d813 
Manually replaces "About CYB" with "About" on mobile
@Sebbben
Merged features from featureBetterRegisterFeedback into changes made …
6322071 
…by pvk05's fixRegisterUserResponse
@Sebbben
added snackbar to singin page
a715fac
@EricSvebakk
Merge branch 'development'
4dfd6f8
@Sebbben
Fixed wrong path for nav bar home from pointing to /home to pointing …
f06a472 
…to /
@EricSvebakk
Merge branch 'pr/53' into development
a1ce2ec
@Borgarsy
adds halloween theme.
d198b94
@EricSvebakk
Merge branch 'main' into development
0f096c0
@EricSvebakk @Sebbben
Squashed commit adding pr/53
bcbc8d1 
commit 0f096c0
Merge: a1ce2ec 4dfd6f8
Author: Tepohe <[email protected]>
Date:   Thu Oct 10 14:42:19 2024 +0200

    Merge branch 'main' into development

commit a1ce2ec
Merge: 4f7d813 f06a472
Author: Tepohe <[email protected]>
Date:   Tue Oct 8 13:53:44 2024 +0200

    Merge branch 'pr/53' into development

commit f06a472
Author: Sebbben <[email protected]>
Date:   Mon Oct 7 16:47:03 2024 +0200

    Fixed wrong path for nav bar home from pointing to /home to pointing to /

commit 0d154f5
Author: Sebbben <[email protected]>
Date:   Thu Sep 26 14:40:51 2024 +0200

    Renamed some directories to take advantage of nexts routing for more usable url paths

Co-Authored-By: Sebbben <[email protected]>
@Sebbben @EricSvebakk
Made tables turn to first page when the table content changes with a …
c019c46 
…search
EricSvebakk and others added 18 commits October 10, 2024 16:54
@EricSvebakk
Merge pull request cybernetisk#67 from Sebbben/fixNoResultMembershipS…
d26bd3f 
…earch

Fix no result membership search
@Sebbben
removed duplicate login button on successfull registration
56dc570
@Sebbben
made it so that pressing enter on signin and register page submits th…
cd922ac 
…e forms
@EricSvebakk @Sebbben
Squashed commit adding pr/67:
420e092 
commit d26bd3f
Merge: 0f096c0 c019c46
Author: Eric Svebakk <[email protected]>
Date:   Thu Oct 10 16:54:40 2024 +0200

    Merge pull request cybernetisk#67 from Sebbben/fixNoResultMembershipSearch

    Fix no result membership search

commit c019c46
Author: Sebbben <[email protected]>
Date:   Sat Oct 5 16:20:01 2024 +0200

    Made tables turn to first page when the table content changes with a search

commit 0f096c0
Merge: a1ce2ec 4dfd6f8
Author: Tepohe <[email protected]>
Date:   Thu Oct 10 14:42:19 2024 +0200

    Merge branch 'main' into development

commit a1ce2ec
Merge: 4f7d813 f06a472
Author: Tepohe <[email protected]>
Date:   Tue Oct 8 13:53:44 2024 +0200

    Merge branch 'pr/53' into development

commit f06a472
Author: Sebbben <[email protected]>
Date:   Mon Oct 7 16:47:03 2024 +0200

    Fixed wrong path for nav bar home from pointing to /home to pointing to /

commit 0d154f5
Author: Sebbben <[email protected]>
Date:   Thu Sep 26 14:40:51 2024 +0200

    Renamed some directories to take advantage of nexts routing for more usable url paths

Co-Authored-By: Sebbben <[email protected]>
@EricSvebakk
Merge pull request cybernetisk#75 from Borgarsy/feature-halloween-theme
f0bacbb 
Temporary Halloween theme
@EricSvebakk @Borgarsy
Squashed commit adding pr/75
3a2cabc 
commit f0bacbb
Merge: d26bd3f d198b94
Author: Eric Svebakk <[email protected]>
Date:   Thu Oct 17 15:46:05 2024 +0200

    Merge pull request cybernetisk#75 from Borgarsy/feature-halloween-theme

    Temporary Halloween theme

commit d26bd3f
Merge: 0f096c0 c019c46
Author: Eric Svebakk <[email protected]>
Date:   Thu Oct 10 16:54:40 2024 +0200

    Merge pull request cybernetisk#67 from Sebbben/fixNoResultMembershipSearch

    Fix no result membership search

commit c019c46
Author: Sebbben <[email protected]>
Date:   Sat Oct 5 16:20:01 2024 +0200

    Made tables turn to first page when the table content changes with a search

commit 0f096c0
Merge: a1ce2ec 4dfd6f8
Author: Tepohe <[email protected]>
Date:   Thu Oct 10 14:42:19 2024 +0200

    Merge branch 'main' into development

commit d198b94
Author: Borgar <[email protected]>
Date:   Tue Oct 8 15:01:29 2024 +0200

    adds halloween theme.

commit a1ce2ec
Merge: 4f7d813 f06a472
Author: Tepohe <[email protected]>
Date:   Tue Oct 8 13:53:44 2024 +0200

    Merge branch 'pr/53' into development

commit f06a472
Author: Sebbben <[email protected]>
Date:   Mon Oct 7 16:47:03 2024 +0200

    Fixed wrong path for nav bar home from pointing to /home to pointing to /

commit 0d154f5
Author: Sebbben <[email protected]>
Date:   Thu Sep 26 14:40:51 2024 +0200

    Renamed some directories to take advantage of nexts routing for more usable url paths

Co-Authored-By: Borgarsy <[email protected]>
@EricSvebakk
Handled merge-conflict
1861431
@EricSvebakk
git push origin developmentMerge branch 'Sebbben-featureBetterRegiste…
73999a8 
…rFeedback' into development

Handled merge-conflict for pr/64
@EricSvebakk
Updated incorrect url-path
8b529ef
@EricSvebakk @pvk05 @Sebbben
Squashed commit adding pr/64
ebe4c43 
commit 8b529ef
Author: Tepohe <[email protected]>
Date:   Thu Oct 17 16:20:05 2024 +0200

    Updated incorrect url-path

commit 73999a8
Merge: f0bacbb 1861431
Author: Eric Svebakk <[email protected]>
Date:   Thu Oct 17 16:11:36 2024 +0200

    git push origin developmentMerge branch 'Sebbben-featureBetterRegisterFeedback' into development
    Handled merge-conflict for pr/64

commit 1861431
Merge: f0bacbb cd922ac
Author: Tepohe <[email protected]>
Date:   Thu Oct 17 16:08:02 2024 +0200

    Handled merge-conflict

commit f0bacbb
Merge: d26bd3f d198b94
Author: Eric Svebakk <[email protected]>
Date:   Thu Oct 17 15:46:05 2024 +0200

    Merge pull request cybernetisk#75 from Borgarsy/feature-halloween-theme

    Temporary Halloween theme

commit cd922ac
Author: Sebbben <[email protected]>
Date:   Fri Oct 11 10:20:45 2024 +0200

    made it so that pressing enter on signin and register page submits the forms

commit 56dc570
Author: Sebbben <[email protected]>
Date:   Fri Oct 11 10:16:44 2024 +0200

    removed duplicate login button on successfull registration

commit d26bd3f
Merge: 0f096c0 c019c46
Author: Eric Svebakk <[email protected]>
Date:   Thu Oct 10 16:54:40 2024 +0200

    Merge pull request cybernetisk#67 from Sebbben/fixNoResultMembershipSearch

    Fix no result membership search

commit c019c46
Author: Sebbben <[email protected]>
Date:   Sat Oct 5 16:20:01 2024 +0200

    Made tables turn to first page when the table content changes with a search

commit 0f096c0
Merge: a1ce2ec 4dfd6f8
Author: Tepohe <[email protected]>
Date:   Thu Oct 10 14:42:19 2024 +0200

    Merge branch 'main' into development

commit d198b94
Author: Borgar <[email protected]>
Date:   Tue Oct 8 15:01:29 2024 +0200

    adds halloween theme.

commit a1ce2ec
Merge: 4f7d813 f06a472
Author: Tepohe <[email protected]>
Date:   Tue Oct 8 13:53:44 2024 +0200

    Merge branch 'pr/53' into development

commit f06a472
Author: Sebbben <[email protected]>
Date:   Mon Oct 7 16:47:03 2024 +0200

    Fixed wrong path for nav bar home from pointing to /home to pointing to /

commit a715fac
Author: Sebbben <[email protected]>
Date:   Tue Oct 1 17:24:53 2024 +0200

    added snackbar to singin page

commit 6322071
Merge: 131cc76 ea38e61
Author: Sebbben <[email protected]>
Date:   Tue Oct 1 17:08:07 2024 +0200

    Merged features from featureBetterRegisterFeedback into changes made by pvk05's fixRegisterUserResponse

commit 131cc76
Merge: 221a968 eb8b2f2
Author: Philip Knudsen <[email protected]>
Date:   Tue Oct 1 16:32:52 2024 +0200

    Merge branch 'cybernetisk:main' into fixRegisterUserResponse

commit 221a968
Author: pvk05 <[email protected]>
Date:   Sat Sep 28 00:57:24 2024 +0200

    moved register response to a snackbar for better visual feedback

commit ea38e61
Author: Sebbben <[email protected]>
Date:   Fri Sep 27 23:41:22 2024 +0200

    added loading indicator to singin page as well

commit 8a3d2de
Author: pvk05 <[email protected]>
Date:   Fri Sep 27 23:14:48 2024 +0200

    checks if email includes "@" before registering user

commit 3f547cf
Author: pvk05 <[email protected]>
Date:   Fri Sep 27 22:44:11 2024 +0200

    fixed response from sendMail function to send correct feedback when failing

commit 0b33808
Author: Sebbben <[email protected]>
Date:   Thu Sep 26 17:07:50 2024 +0200

    visual queue when registering user

commit 0d154f5
Author: Sebbben <[email protected]>
Date:   Thu Sep 26 14:40:51 2024 +0200

    Renamed some directories to take advantage of nexts routing for more usable url paths

Co-Authored-By: Philip Knudsen <[email protected]>
Co-Authored-By: Sebbben <[email protected]>
@Sebbben
moved pages/main/board/* to (pages)/(main)/board
ac17a6e
@EricSvebakk
Merge pull request cybernetisk#82 from Sebbben/moveBoardPage
cbe876a 
Move board page
@Sebbben @EricSvebakk
Implementet default filter parameters for customtable component
6beb84d
@EricSvebakk
Merge pull request cybernetisk#81 from Sebbben/betterUsabilityForCust…
1b1e2db 
…omTableComponent

Better usability for custom table component
@yrjarv @EricSvebakk
Fix prisma request for membership creation
34c3184
@EricSvebakk
Merge pull request cybernetisk#62 from yrjarv/membership-comment
b5dde20 
Fix prisma request for membership creation
@EricSvebakk
Updated Membership schema
92a0b1e
@yrjarv
Implement custom input field
e507280 
This input field has an x to remove contents and set focus. I have only used it on the membership page, but it can probably be reused elsewhere too
@yrjarv yrjarv requested a review from EricSvebakk November 13, 2024 10:40
@Sebbben
Copy link
Contributor

Sebbben commented Nov 13, 2024

Smart using input adornments, but the adornment is lacking responsiveness, so its not totally clear that it will clear the input field. I suggest adding some hover styling to the color and the cursor in some way to make it obvious that its clickable

yrjarv added a commit to yrjarv/internsystem-v2 that referenced this pull request Nov 18, 2024
@yrjarv
Reimplement cybernetisk#88
5e45589
@yrjarv yrjarv mentioned this pull request Nov 18, 2024
Open
@yrjarv
Copy link
Member Author

yrjarv commented Nov 18, 2024

Closing, this has been replaced by #99 because of the API changes

@yrjarv yrjarv closed this Nov 18, 2024
@yrjarv yrjarv deleted the reset-input-fields branch November 18, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricSvebakk EricSvebakk Awaiting requested review from EricSvebakk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yrjarv @Sebbben @EricSvebakk @pvk05 @Borgarsy