Fix laser publisher #425
Merged
Fix laser publisher #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe I started from #212, so I didn't notice the implementation is different from the one in |
ad-daniel
added a commit
that referenced
this pull request
May 25, 2022
* Fix position + velocity control in ros2_control (#415) * Fix position + velocity control in ros2_control * Fix camera FoV * fix * Remove timer * Add acceleration * change camera info qos * fix rate * fix * Fix laser publisher (#425) * Allow custom ros2_control hardware_interface (#426) * Fix motor without sensor (#428) * include string (#434) Signed-off-by: Kenji Brameld <[email protected]> * CallbackReturn should include namespae in its signature (#435) Signed-off-by: Kenji Brameld <[email protected]> Co-authored-by: ad-daniel <[email protected]> * use new bbox msg signature (#433) * Handle new bbox msg signature from humble onwards Signed-off-by: Kenji Brameld <[email protected]> Co-authored-by: Olivier Michel <[email protected]> * Fix pep257 D407 Missing dashed underline after section (#437) * fix pep257 D407 Missing dashed underline after section Signed-off-by: Kenji Brameld <[email protected]> Co-authored-by: Olivier Michel <[email protected]> * bump python version to 3.10 for rolling (#436) * bump python version to 3.10 for rolling * use different python versions depending on distros * update submodule to most recent R2022a Signed-off-by: Kenji Brameld <[email protected]> Co-authored-by: Olivier Michel <[email protected]> * Change call to spawner.py executable to spawner (#438) * rename spawner.py executable to spawner Signed-off-by: Kenji Brameld <[email protected]> * use spawner.py if on foxy Signed-off-by: Kenji Brameld <[email protected]> * Sync * Revert "Sync" This reverts commit 262da4c. * revert * Revert "revert" This reverts commit ccece71. * Sync * Fix ci * Fix * Fix extern controllers * Fix merge * Again * Test extern * Revert "Merge branch 'master' into fix-synchronize-libcontroller" This reverts commit 09940ed, reversing changes made to f731f86. * Fix extern controllers * Undo change * more Co-authored-by: Darko Lukić <[email protected]> Co-authored-by: Kenji Brameld <[email protected]> Co-authored-by: Olivier Michel <[email protected]>
ad-daniel
added a commit
that referenced
this pull request
Sep 9, 2022
* Fix position + velocity control in ros2_control (#415) * Fix position + velocity control in ros2_control * Fix camera FoV * fix * Remove timer * Add acceleration * change camera info qos * fix rate * fix * Fix laser publisher (#425) * Allow custom ros2_control hardware_interface (#426) * Fix motor without sensor (#428) * Fix * Fix * Fix merge * Fix * include string (#434) Signed-off-by: Kenji Brameld <[email protected]> * CallbackReturn should include namespae in its signature (#435) Signed-off-by: Kenji Brameld <[email protected]> Co-authored-by: ad-daniel <[email protected]> * use new bbox msg signature (#433) * Handle new bbox msg signature from humble onwards Signed-off-by: Kenji Brameld <[email protected]> Co-authored-by: Olivier Michel <[email protected]> * Fix pep257 D407 Missing dashed underline after section (#437) * fix pep257 D407 Missing dashed underline after section Signed-off-by: Kenji Brameld <[email protected]> Co-authored-by: Olivier Michel <[email protected]> * bump python version to 3.10 for rolling (#436) * bump python version to 3.10 for rolling * use different python versions depending on distros * update submodule to most recent R2022a Signed-off-by: Kenji Brameld <[email protected]> Co-authored-by: Olivier Michel <[email protected]> * Change call to spawner.py executable to spawner (#438) * rename spawner.py executable to spawner Signed-off-by: Kenji Brameld <[email protected]> * use spawner.py if on foxy Signed-off-by: Kenji Brameld <[email protected]> * Sync (#445) * prepare version 1.2.3 (#402) * prepare version 1.2.3 * update libcontroller * install manually libpython3-dev * test python 3.9 rolling * removed install lib-python-dev * typo * update libcontroller * Upgrade webots_ros2_importer * fix std string * flake 8 fix importer * lidar new value * changelog importer * Fixes * Fix for foxy, galactic * Added GALACTIC definition * Update CHANGELOG.rst * Update CHANGELOG.rst * Update CHANGELOG.rst * Updated changelog * Added humble * skip broken tests * Fixed tests * fix * Update ci_after_init.bash * Update ci_after_init.bash * Fix build * Fix compilation * simplified * Possible fix * Fix * Synch urdf2webots to latest * Fixed a compilation warning with python 3.10 * Apply openssl patch * Fix path * Add debug message * debug * Fix * Fix * Debug * Hardcode * Increase timeout * Rolling fix * Revert "Rolling fix" This reverts commit ec39e10. * Test * Revert * Fixed wrong condition * Fix * Rework * Attempt to fix testing * Missing case * Rework * Fix * Fix * Update changelogs * Upgrade urdf2webots to 1.0.18 * Review fix Co-authored-by: Olivier Michel <[email protected]> Co-authored-by: ad-daniel <[email protected]> Co-authored-by: ad-daniel <[email protected]> * Fix build from repo (#452) * Fix build from repo * Fix * Fix changelog * Add nightly tests (#453) * Add nightly tests * Fix humble after sync * Make develop tests only nightly * Sync * Fix test * Test urdf2webots branch * Adapt to urdf2webots changes * revert urdf * Sync urdf2webots * Test * Fix style * update libcontroller * Add declaration to worlds (#456) * update urls (#457) * Fix master nightly (#459) * Fix master nightly * Add R * Revert nightly URL change * Sync libcontroller Signed-off-by: Kenji Brameld <[email protected]> Co-authored-by: Darko Lukić <[email protected]> Co-authored-by: Kenji Brameld <[email protected]> Co-authored-by: Olivier Michel <[email protected]> Co-authored-by: Benjamin Hug <[email protected]>
ad-daniel
added a commit
that referenced
this pull request
Sep 23, 2022
* remove no sandbox references + pep8 compliance * pep8 * Update scripts/ci_before_init_embed.bash Co-authored-by: Olivier Michel <[email protected]> * update libcontroller * update libcontroller * update lib controller * Feature URDF import on the fly (#345) * init * init urdf importer on the fly * example universal robot * change example URDF in universal robot * begin work supervisor * temp commit * separate launcher webots and ROS nodes * test send clean urdf * ctrl + c catched * temp test catch signal driver node * temp catch SIGINT node * temp test add_pre_shutdown_callback * functionnality works, start cleaning * temp cleaning * cleaned launch webots * converted first example * converted 2nd example * temp commit freeze simulation * prepare push * urdf importer and universal_robot example ready * remove xacro conversion * update use of urdf2webots * temp fix paths world file * temp * temp test path world * temp * world file relative paths fix * mix of option isProto and robotName URDF conversion * change dependency urdf2webots * typo fix * Clean * More cleaning * Simplify use of Ros2Supervisor * timeout test * foxy and galactic exception * test ros bag * fix * Review * msgs rename * msgs rename fix camera * fix brackets url * printenv test * exit change * qt debug * test print env inside webots launcher * force install rviz * remove debug * test depend rviz * rviz visual tools * clean * Feature /clock topic published by Ros2Supervisor (#395) * clock topic published by Ros2Supervisor * fix * test printenv * remove test * fix * Apply suggestions from code review Co-authored-by: Olivier Michel <[email protected]> * signal handler flag intern to WebotsNode * signal handler fully intergrated * enable restart webots * re implemented signal handler in driver * correct signal handler only in webotsNode * enable conversion from robot_description * convert from URDF content * Update webots_ros2_driver/webots_ros2_driver/urdf_spawner.py Co-authored-by: Olivier Michel <[email protected]> * conversion urdf content (xacro) and refresh sim * fix flake8 * remove unused package * Apply suggestions from code review Co-authored-by: Olivier Michel <[email protected]> Co-authored-by: Olivier Michel <[email protected]> * Remove extra URDF file for universal_robot Moveit (#416) Remove extra URDF file for universal_robot Moveit scenario * Synchronize libcontroller (#444) * Fix position + velocity control in ros2_control (#415) * Fix position + velocity control in ros2_control * Fix camera FoV * fix * Remove timer * Add acceleration * change camera info qos * fix rate * fix * Fix laser publisher (#425) * Allow custom ros2_control hardware_interface (#426) * Fix motor without sensor (#428) * include string (#434) Signed-off-by: Kenji Brameld <[email protected]> * CallbackReturn should include namespae in its signature (#435) Signed-off-by: Kenji Brameld <[email protected]> Co-authored-by: ad-daniel <[email protected]> * use new bbox msg signature (#433) * Handle new bbox msg signature from humble onwards Signed-off-by: Kenji Brameld <[email protected]> Co-authored-by: Olivier Michel <[email protected]> * Fix pep257 D407 Missing dashed underline after section (#437) * fix pep257 D407 Missing dashed underline after section Signed-off-by: Kenji Brameld <[email protected]> Co-authored-by: Olivier Michel <[email protected]> * bump python version to 3.10 for rolling (#436) * bump python version to 3.10 for rolling * use different python versions depending on distros * update submodule to most recent R2022a Signed-off-by: Kenji Brameld <[email protected]> Co-authored-by: Olivier Michel <[email protected]> * Change call to spawner.py executable to spawner (#438) * rename spawner.py executable to spawner Signed-off-by: Kenji Brameld <[email protected]> * use spawner.py if on foxy Signed-off-by: Kenji Brameld <[email protected]> * Sync * Revert "Sync" This reverts commit 262da4c. * revert * Revert "revert" This reverts commit ccece71. * Sync * Fix ci * Fix * Fix extern controllers * Fix merge * Again * Test extern * Revert "Merge branch 'master' into fix-synchronize-libcontroller" This reverts commit 09940ed, reversing changes made to f731f86. * Fix extern controllers * Undo change * more Co-authored-by: Darko Lukić <[email protected]> Co-authored-by: Kenji Brameld <[email protected]> Co-authored-by: Olivier Michel <[email protected]> * Merge `master` into `develop` (#430) * Fix position + velocity control in ros2_control (#415) * Fix position + velocity control in ros2_control * Fix camera FoV * fix * Remove timer * Add acceleration * change camera info qos * fix rate * fix * Fix laser publisher (#425) * Allow custom ros2_control hardware_interface (#426) * Fix motor without sensor (#428) * Fix * Fix * Fix merge * Fix * include string (#434) Signed-off-by: Kenji Brameld <[email protected]> * CallbackReturn should include namespae in its signature (#435) Signed-off-by: Kenji Brameld <[email protected]> Co-authored-by: ad-daniel <[email protected]> * use new bbox msg signature (#433) * Handle new bbox msg signature from humble onwards Signed-off-by: Kenji Brameld <[email protected]> Co-authored-by: Olivier Michel <[email protected]> * Fix pep257 D407 Missing dashed underline after section (#437) * fix pep257 D407 Missing dashed underline after section Signed-off-by: Kenji Brameld <[email protected]> Co-authored-by: Olivier Michel <[email protected]> * bump python version to 3.10 for rolling (#436) * bump python version to 3.10 for rolling * use different python versions depending on distros * update submodule to most recent R2022a Signed-off-by: Kenji Brameld <[email protected]> Co-authored-by: Olivier Michel <[email protected]> * Change call to spawner.py executable to spawner (#438) * rename spawner.py executable to spawner Signed-off-by: Kenji Brameld <[email protected]> * use spawner.py if on foxy Signed-off-by: Kenji Brameld <[email protected]> * Sync (#445) * prepare version 1.2.3 (#402) * prepare version 1.2.3 * update libcontroller * install manually libpython3-dev * test python 3.9 rolling * removed install lib-python-dev * typo * update libcontroller * Upgrade webots_ros2_importer * fix std string * flake 8 fix importer * lidar new value * changelog importer * Fixes * Fix for foxy, galactic * Added GALACTIC definition * Update CHANGELOG.rst * Update CHANGELOG.rst * Update CHANGELOG.rst * Updated changelog * Added humble * skip broken tests * Fixed tests * fix * Update ci_after_init.bash * Update ci_after_init.bash * Fix build * Fix compilation * simplified * Possible fix * Fix * Synch urdf2webots to latest * Fixed a compilation warning with python 3.10 * Apply openssl patch * Fix path * Add debug message * debug * Fix * Fix * Debug * Hardcode * Increase timeout * Rolling fix * Revert "Rolling fix" This reverts commit ec39e10. * Test * Revert * Fixed wrong condition * Fix * Rework * Attempt to fix testing * Missing case * Rework * Fix * Fix * Update changelogs * Upgrade urdf2webots to 1.0.18 * Review fix Co-authored-by: Olivier Michel <[email protected]> Co-authored-by: ad-daniel <[email protected]> Co-authored-by: ad-daniel <[email protected]> * Fix build from repo (#452) * Fix build from repo * Fix * Fix changelog * Add nightly tests (#453) * Add nightly tests * Fix humble after sync * Make develop tests only nightly * Sync * Fix test * Test urdf2webots branch * Adapt to urdf2webots changes * revert urdf * Sync urdf2webots * Test * Fix style * update libcontroller * Add declaration to worlds (#456) * update urls (#457) * Fix master nightly (#459) * Fix master nightly * Add R * Revert nightly URL change * Sync libcontroller Signed-off-by: Kenji Brameld <[email protected]> Co-authored-by: Darko Lukić <[email protected]> Co-authored-by: Kenji Brameld <[email protected]> Co-authored-by: Olivier Michel <[email protected]> Co-authored-by: Benjamin Hug <[email protected]> * Target R2022b in the automatic webots installation script (#469) * Fix target version * Fix nightly name * Fix nightly * Sync libcontroller * Fix update rate * Revert "Fix update rate" This reverts commit c48620d. * Sync * Simplify world * Minor * Patched webots * sanity check * Restore * Minor Signed-off-by: Kenji Brameld <[email protected]> Co-authored-by: joachimhgg <[email protected]> Co-authored-by: Benjamin Hug <[email protected]> Co-authored-by: Benjamin Hug <[email protected]> Co-authored-by: Olivier Michel <[email protected]> Co-authored-by: joachimhgg <[email protected]> Co-authored-by: Darko Lukić <[email protected]> Co-authored-by: Kenji Brameld <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses: #424
Currently on the tiago example, slam_toolbox complains about the number of range readings not matching.
The change was introduced here #367, however I'm not certain why. As far as I can tell, for slam_toolbox the range should be inclusive, so
[-0.5*FOV, 0.5*FOV], which is also how it was implemented in webots_ros2_core . @lukicdarkoo do you recall perhaps why the change was done?