-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make some members protected in WebotsNode.hpp #291
Conversation
…development and ideas' try
…er be protected for users' further development and ideas' try
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exposing more of API means more maintenance and less flexibility on our side. Could you please tell me your use case?
Oh, sorry, I ignored them suddenly, robot() and urdf() are enough. |
Could you please propose changes to: |
It takes long time, I will try it if I have enough free time. I want to ask/confirm: mRobotDescription = this->declare_parameterstd::string("robot_description", "") for webots devices/plugin configuration. the "robot_description" seems to conflict with robot_state_publisher's ??? for better understanding, can we rename the variable name and parameter name, like robot_configuration or webots_configuration |
The parameter name is the same, but the node name is not. To change a parameter, you have to specify a node name as well. Therefore, there are no conflicts. I wouldn't rename it because we want to implement full URDF support: |
Wow! That's a good news! |
We have some ideas on how to implement it, but we haven't settled on anything. Once we do a detailed plan we will be able to estimate the time of release. |
Currently, how could we get webots robot's urdf (Robot::getUrdf) in other ros nodes? |
You read the |
Make some members protected in WebotsNode.hpp for users' further development and ideas' try
mRobot
mRobotName
mRobotDescription
mClient s
setAnotherNodeParameter