Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix I2C device numbers #31

Merged
merged 4 commits into from
Nov 23, 2023
Merged

Fix I2C device numbers #31

merged 4 commits into from
Nov 23, 2023

Conversation

lukicdarkoo
Copy link
Member

The I2C device number is changed for the new e-pucks, see:
gctronic/Pi-puck@bc50619

omichel
omichel previously approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lukicdarkoo lukicdarkoo requested a review from omichel November 23, 2023 09:34
@lukicdarkoo
Copy link
Member Author

Sorry, I missed the CI failure, it should be fine now

omichel
omichel approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@omichel omichel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I thought the tests were failing for another reason since foxy is now deprecated.

@lukicdarkoo lukicdarkoo merged commit 91ff8a1 into master Nov 23, 2023
2 checks passed
@omichel omichel deleted the fix-i2c-device branch November 23, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omichel omichel omichel approved these changes

Assignees

@lukicdarkoo lukicdarkoo

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukicdarkoo @omichel