Skip to content

Commit

Permalink
Fix unregistering event handler
Browse files Browse the repository at this point in the history
  • Loading branch information
@cyanfish
cyanfish committed Mar 10, 2024
1 parent a80880b commit a3c4104
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions NAPS2.Lib/EtoForms/Ui/PreviewForm.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,7 @@ protected override void Dispose(bool disposing)
{
ImageViewer.Image?.Dispose();
ImageViewer.Image = null;
ImageList.ImagesUpdated -= ImageList_ImagesUpdated;

Check warning on line 383 in NAPS2.Lib/EtoForms/Ui/PreviewForm.cs

View workflow job for this annotation

GitHub Actions / build (windows-2022) 

Nullability of reference types in type of parameter 'sender' of 'void PreviewForm.ImageList_ImagesUpdated(object sender, ImageListEventArgs e)' doesn't match the target delegate 'EventHandler<ImageListEventArgs>' (possibly because of nullability attributes).

Check warning on line 383 in NAPS2.Lib/EtoForms/Ui/PreviewForm.cs

View workflow job for this annotation

GitHub Actions / build (windows-2022) 

Nullability of reference types in type of parameter 'sender' of 'void PreviewForm.ImageList_ImagesUpdated(object sender, ImageListEventArgs e)' doesn't match the target delegate 'EventHandler<ImageListEventArgs>' (possibly because of nullability attributes).

Check warning on line 383 in NAPS2.Lib/EtoForms/Ui/PreviewForm.cs

View workflow job for this annotation

GitHub Actions / build (windows-2022) 

Nullability of reference types in type of parameter 'sender' of 'void PreviewForm.ImageList_ImagesUpdated(object sender, ImageListEventArgs e)' doesn't match the target delegate 'EventHandler<ImageListEventArgs>' (possibly because of nullability attributes).

Check warning on line 383 in NAPS2.Lib/EtoForms/Ui/PreviewForm.cs

View workflow job for this annotation

GitHub Actions / build (windows-2022) 

Nullability of reference types in type of parameter 'sender' of 'void PreviewForm.ImageList_ImagesUpdated(object sender, ImageListEventArgs e)' doesn't match the target delegate 'EventHandler<ImageListEventArgs>' (possibly because of nullability attributes).

Check warning on line 383 in NAPS2.Lib/EtoForms/Ui/PreviewForm.cs

View workflow job for this annotation

GitHub Actions / build (windows-2022) 

Nullability of reference types in type of parameter 'sender' of 'void PreviewForm.ImageList_ImagesUpdated(object sender, ImageListEventArgs e)' doesn't match the target delegate 'EventHandler<ImageListEventArgs>' (possibly because of nullability attributes).

Check warning on line 383 in NAPS2.Lib/EtoForms/Ui/PreviewForm.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-22.04) 

Nullability of reference types in type of parameter 'sender' of 'void PreviewForm.ImageList_ImagesUpdated(object sender, ImageListEventArgs e)' doesn't match the target delegate 'EventHandler<ImageListEventArgs>' (possibly because of nullability attributes).

Check warning on line 383 in NAPS2.Lib/EtoForms/Ui/PreviewForm.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-22.04) 

Nullability of reference types in type of parameter 'sender' of 'void PreviewForm.ImageList_ImagesUpdated(object sender, ImageListEventArgs e)' doesn't match the target delegate 'EventHandler<ImageListEventArgs>' (possibly because of nullability attributes).

Check warning on line 383 in NAPS2.Lib/EtoForms/Ui/PreviewForm.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-22.04) 

Nullability of reference types in type of parameter 'sender' of 'void PreviewForm.ImageList_ImagesUpdated(object sender, ImageListEventArgs e)' doesn't match the target delegate 'EventHandler<ImageListEventArgs>' (possibly because of nullability attributes).

Check warning on line 383 in NAPS2.Lib/EtoForms/Ui/PreviewForm.cs

View workflow job for this annotation

GitHub Actions / build (macos-14) 

Nullability of reference types in type of parameter 'sender' of 'void PreviewForm.ImageList_ImagesUpdated(object sender, ImageListEventArgs e)' doesn't match the target delegate 'EventHandler<ImageListEventArgs>' (possibly because of nullability attributes).

Check warning on line 383 in NAPS2.Lib/EtoForms/Ui/PreviewForm.cs

View workflow job for this annotation

GitHub Actions / build (macos-14) 

Nullability of reference types in type of parameter 'sender' of 'void PreviewForm.ImageList_ImagesUpdated(object sender, ImageListEventArgs e)' doesn't match the target delegate 'EventHandler<ImageListEventArgs>' (possibly because of nullability attributes).

Check warning on line 383 in NAPS2.Lib/EtoForms/Ui/PreviewForm.cs

View workflow job for this annotation

GitHub Actions / build (macos-14) 

Nullability of reference types in type of parameter 'sender' of 'void PreviewForm.ImageList_ImagesUpdated(object sender, ImageListEventArgs e)' doesn't match the target delegate 'EventHandler<ImageListEventArgs>' (possibly because of nullability attributes).

Check warning on line 383 in NAPS2.Lib/EtoForms/Ui/PreviewForm.cs

View workflow job for this annotation

GitHub Actions / build (macos-14) 

Nullability of reference types in type of parameter 'sender' of 'void PreviewForm.ImageList_ImagesUpdated(object sender, ImageListEventArgs e)' doesn't match the target delegate 'EventHandler<ImageListEventArgs>' (possibly because of nullability attributes).
}
base.Dispose(disposing);
}
Expand Down

0 comments on commit a3c4104

Please sign in to comment.