Skip to content

Commit

Permalink
seccomp: Stub for !HAVE_ARCH_SECCOMP_FILTER
Browse files Browse the repository at this point in the history
If we have CONFIG_SECCOMP but not CONFIG_HAVE_ARCH_SECCOMP_FILTER
we get a compilation error:

../kernel/entry/common.c: In function 'syscall_trace_enter':
../kernel/entry/common.c:55:23: error: implicit declaration of function '__secure_computing' [-Werror=implicit-function-declaration]
   55 |                 ret = __secure_computing(NULL);
      |                       ^~~~~~~~~~~~~~~~~~

This is because generic entry calls __secure_computing()
unconditionally.

Provide the needed stub similar to how current ARM does
this by calling secure_computing_strict() in the absence
of secure_computing(). This is similar to what is done for
ARM in arch/arm/kernel/ptrace.c.

Signed-off-by: Linus Walleij <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Kees Cook <[email protected]>
  • Loading branch information
linusw authored and kees committed Oct 22, 2024
1 parent 8cf0b93 commit 8cf8dfc
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions include/linux/seccomp.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ static inline int secure_computing(void)
}
#else
extern void secure_computing_strict(int this_syscall);
static inline int __secure_computing(const struct seccomp_data *sd)
{
secure_computing_strict(sd->nr);
return 0;
}
#endif

extern long prctl_get_seccomp(void);
Expand Down

0 comments on commit 8cf8dfc

Please sign in to comment.