Update dependency rubocop to '~> 0.93', '>= 0.93.1' #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mend-5034428[bot]](https://avatars.githubusercontent.com/u/5034428?s=60&v=4){kind=small}
mend-5034428
bot
changed the title
mend-5034428
bot
changed the title
mend-5034428
bot
changed the title
mend-5034428
bot
changed the title
mend-5034428
bot
changed the title
mend-5034428
bot
changed the title
mend-5034428
bot
changed the title
mend-5034428
bot
changed the title
mend-5034428
bot
changed the title
mend-5034428
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
'~> 0.34'->'~> 0.93', '>= 0.93.1'Release Notes
rubocop/rubocop (rubocop)
v0.93.1Compare Source
Bug fixes
Style/TernaryParentheseswithdefined?. ([@dvandersluis][])Lint/RedundantSafeNavigationto be more safe. ([@fatkodima][])Style/RedundantBeginwith a postfixwhileoruntil. ([@dvandersluis][])Style/RedundantBeginwhen usingbeginfor or assignment and method call. ([@koic][])Lint/AmbiguousRegexpLiteralwhen using regexp without method calls in nested structure. ([@koic][])Metrics/ClassLengthwhen multiple assignments to constants. ([@koic][])Style/RedundantBeginwhen usingbeginfor method argument or part of conditions. ([@koic][])Style/ClassEqualityComparisonwhen comparing class name. ([@koic][])Style/ClassLengthwhen overlapping constant assignments. ([@koic][])v0.93.0Compare Source
New features
Lint/HashCompareByIdentitycop. ([@fatkodima][])Style/ClassEqualityComparisoncop. ([@fatkodima][])Lint/RedundantSafeNavigationcop. ([@fatkodima][])Style/RedundantBeginaware ofbeginwithoutrescueorensure. ([@koic][])Lint/NoReturnInBeginEndBlockscop. ([@jcfausto][])Bug fixes
Style/RaiseArgs. ([@pbernays][])Lint/BooleanSymbolwhen used within%i[...]. ([@fatkodima][])Style/For. ([@pbernays][])Layout/SpaceAroundEqualsInParameterDefaultonly registered once in a line. ([@rdunlop][])Style/MethodDefParenthesesper file. ([@rdunlop][])Style/ExplicitBlockArgumentwhen code is called outside of a method. ([@ghiculescu][])Style/CaseLikeIfcop. ([@dsavochkin][])Style/NestedTernaryOperatorwhen using a nested ternary operator expression with no parentheses on the outside. ([@koic][])Style/ParenthesesAsGroupedExpressionwhen method argument parentheses are omitted and hash argument key is enclosed in parentheses. ([@koic][])Style/StringConcatenationwhen string includes double quotes. ([@tleish][])Style/RedundantConditionwhen using assignment by hash key access. ([@koic][])Style/CombinableLoopswhen using the same method with different arguments. ([@dvandersluis][])Lint/AmbiguousRegexpLiteralwhen sending method to regexp literal receiver. ([@koic][])Style/RedundantInterpolationwhen using string interpolation for non-operator methods. ([@koic][])Lint/AmbiguousBlockAssociationcop. ([@AllanSiqueira][])Layout/EmptyLinesAroundAccessModifierandStyle/AccessModifierDeclarationswhen using only access modifier. ([@koic][])Changes
RegexpNode#parsed_treenow processes regexps including interpolation (by blanking the interpolation before parsing, rather than skipping). ([@owst][])Style/RedundantRegexpCharacterClassandStyle/RedundantRegexpEscapeby usingregexp_parsergem. ([@owst][])TargetFinderclass which improves initial startup speed. ([@tleish][])Struct.new. ([@tejasbubane][])Gemspec/RequiredRubyVersioncop aware ofGem::Requirement. ([@tejasbubane][])v0.92.0Compare Source
New features
--regenerate-todo. ([@dvandersluis][])AllowedMethodsoption toStyle/OptionalBooleanParametercop. ([@fatkodima][])Style/DateTime. ([@dvandersluis][])Bug fixes
Layout/ArrayAlignmentwith parallel assignment. ([@dvandersluis][])Changes
TargetFinderclass which improves rubocop initial startup speed. ([@tleish][])Style/ArrayCoercioncop by default. ([@koic][])v0.91.1Compare Source
Bug fixes
Lint/IdentityComparisonwhen callingobject_idmethod without receiver in LHS or RHS. ([@koic][])Style/RedundantReturnwhen a rescue has an else clause. ([@fatkodima][])Layout/RescueEnsureAlignmentwhenLayout/BeginEndAlignmentcop is not enabled status. ([@koic][])Naming/VariableNumberwhen naming multibyte character variable name. ([@koic][])Lint/UselessTimeswhen there is a blank line in the method definition. ([@koic][])Style/HashAsLastArrayItemwhen the hash is in an implicit array. ([@dvandersluis][])Lint/UselessTimeswhen using empty block argument. ([@koic][])Metrics/AbcSize. ([@marcandre][])Style/MultilineWhenThenwhen line break for multiple candidate values ofwhenstatement. ([@koic][])Style/RandomWithOffsetwhen using a range with non-integer bounds. ([@eugeneius][])Layout/EmptyLinesAroundAccessModifierwithLayout/EmptyLinesAroundBlockBodywhen using access modifier with block argument. ([@koic][])Lint/RedundantCopEnableDirectiveautocorrection to not leave orphaned empty# rubocop:enablecomments. ([@dvandersluis][])Lint/RedundantCopDisableDirectiveautocorrection. ([@dvandersluis][])Layout/CaseIndentationnot showing the cop name in output messages. ([@dvandersluis][])Style/OneLineConditionalwhen usingif-then-elsif-then-end. ([@koic][])Style/IfUnlessModifierto ignore cop disable comment directives when considering conversion to the modifier form. ([@dsavochkin][])Changes
respond_to_missing?fromOptionalBooleanParametercop. ([@em-gazelle][])Style/SafeNavigationmarked as having unsafe auto-correction. ([@marcandre][])Style/IpAddressesby default inGemfileand gemspec files. ([@dvandersluis][])v0.91.0Compare Source
New features
--cache-rootand support for theRUBOCOP_CACHE_ROOTenvironment variable. Both can be used to override theAllCops: CacheRootDirectoryconfig, especially in a CI setting. ([@sascha-wolf][])Layout/BeginEndAlignmentcop. ([@koic][])Lint/IdentityComparisoncop. ([@koic][])Lint/UselessTimescop. ([@dvandersluis][])Lint/ConstantDefinitionInBlockcop. ([@eugeneius][])Bug fixes
Lint/DuplicateRequirewhen same feature argument but different require method. ([@koic][])Layout/EmptyLineAfterMultilineConditionwhen conditional is at the top level. ([@fatkodima][])Style/RedundantSelfAssignmentwhen calling coercion methods. ([@fatkodima][])Lint/EmptyFile. ([@fatkodima][])Lint/UnreachableLoopwhen conditional branch includes continue statement preceding break statement. ([@fatkodima][])Style/RedundantParentheseswhen parentheses are used like method argument parentheses. ([@koic][])Style/HashTransformKeysandStyle/HashTransformValueswhen the receiver is an array. ([@eugeneius][])Layout/DefEndAlignmentwhen using refinements andprivate def. ([@koic][])Style/ClassAndModuleChildrenwhen using cbase class name. ([@koic][])Style/SafeNavigationwhen checkingfoo&.empty?in a conditional. ([@koic][])Style/ClassAndModuleChildrenwhen using cbase module name. ([@koic][])Naming/BinaryOperatorParameterNamewhen naming multibyte character method name. ([@koic][])Bundler/DuplicatedGemwhen gem is duplicated in condition. ([@tejasbubane][])Style/ExplicitBlockArgumentwhen using safe navigation method call. ([@koic][])Style/HashAsLastArrayItemwithno_bracesfor empty hash. ([@fsateler][])Style/HashTransformKeysandStyle/HashTransformValueswhen theeach_with_objecthash is used in the transformed key or value. ([@eugeneius][])Style/GlobalStdStreamas unsafe autocorrection. ([@marcandre][])Style/SpaceInsideHashLiteralBraceswhen a correct empty hash precedes the incorrect hash. ([@dvandersluis][])Lint/UselessMethodDefinition. ([@marcandre][])Lint/AmbiguousOperatorwhen using safe navigation operator with a unary operator. ([@koic][])Style/MultilineTernaryOperatorwhen returning a multiline ternary operator expression. ([@koic][])Style/CaseEqualitycop when the receiver is not a camel cased constant. ([@koic][])--format=jsonand--stdinoptions. ([@koic][])Changes
Style/StringConcatenationwhen parts of the expression are too complex. ([@dvandersluis][])Lint/UselessMethodDefinitionto not register an offense when method definition includes optional arguments. ([@fatkodima][])Style/HashAsLastArrayItemto not register an offense when all items in an array are hashes. ([@dvandersluis][])in?to AllowedMethods forLint/SafeNavigationChaincop. ([@tejasbubane][])mtime, which changes each CI build. ([@dvandersluis][])Style/ClassMethodsDefinitions. ([@dvandersluis][])v0.90.0Compare Source
New features
Style/RedundantSelfAssignmentcop. ([@fatkodima][])Layout/EmptyLineAfterMultilineConditioncop. ([@fatkodima][])Style/SoleNestedConditionalcop. ([@fatkodima][])Style/KeywordParametersOrdercop. ([@fatkodima][])Style/CombinableLoopscop. ([@fatkodima][])Style/ClassMethodsDefinitionscop. ([@fatkodima][])Lint/DuplicateRequirecop. ([@fatkodima][])Lint/UselessMethodDefinitioncop. ([@fatkodima][])Lint/EmptyFilecop. ([@fatkodima][])Lint/TrailingCommaInAttributeDeclarationcop. ([@drenmi][]):restore_registrycontext andstub_cop_classhelper class. ([@marcandre][])Cop.documentation_url. ([@marcandre][])RegexpNode#each_captureandparsed_tree. ([@marcandre][])on_sendcan be optimized by defining the constantRESTRICT_ON_SENDwith a list of acceptable method names. ([@marcandre][])Bug fixes
Style/CaseLikeIfwhen conditional contains comparison with a class. MarkStyle/CaseLikeIfas not safe. ([@fatkodima][])Layout/EmptyLineBetweenDefs. ([@fatkodima][])Lint/BinaryOperatorWithIdenticalOperandsfor binary operators used as unary operators. ([@marcandre][])Bundler/GemComment. ([@pocke][])Style/RescueModifierto handle parentheses around rescue modifiers. ([@dsavochkin][])Style/CaseEqualitycop when comparing with===against a regular expression receiver. ([@koic][])Layout/EmptyLinesAroundClassBodyandLayout/EmptyLinesAroundModuleBodyto correctly handle an access modifier as a first child. ([@dsavochkin][])Lint/ConstantResolutioncop reporting offense formoduleandclassdefinitions. ([@tejasbubane][])Style/MultilineWhenThencop to correctly handle cases with multiline body. ([@dsavochkin][])Style/OneLineConditionalcop to handle if/then/elsif/then/else/end cases. AddAlwaysCorrectToMultilineconfig option to this cop to always convert offenses to the multi-line form (false by default). ([@Lykos][], [@dsavochkin][])Layout/{Def}EndAlignment,Lint/EmptyEnsure,Style/ClassAndModuleChildren. ([@marcandre][])Style/RedundantRegexpEscapefalse positive for line continuations. ([@owst][])Style/RedundantRegexpCharacterClassfalse positive for interpolated multi-line expressions. ([@owst][])Style/CaseLikeIfcop where it does not properly handle overridden equality methods with no arguments. ([@Skipants][])Changes
.rubocop.ymlas well as a notice aboutNewCops: enableconfig option. ([@colszowka][])Lint/ShadowingOuterLocalVariabledocumentation. ([@chocolateboy][])Style/HashTransformKeysandStyle/HashTransformValuesaware ofto_hwith block. ([@eugeneius][])Style/FrozenStringLiteralCommentasSafe, but with unsafe auto-correction. ([@marcandre][])to_enum(:scan, regexp)to work on TruffleRuby. ([@jaimerave][])v0.89.1Compare Source
Bug fixes
Lint/OutOfRangeRegexpRefwhen a regexp is defined and matched in separate steps. ([@eugeneius][])when,grep,gsub,gsub!,sub,sub!,[],slice,slice!,scan,index,rindex,partition,rpartition,start_with?, andend_with?inLint/OutOfRangeRegexpRef. ([@eugeneius][])Lint/UriRegexpwhen usingregexpmethod without receiver. ([@koic][])Lint/BinaryOperatorWithIdenticalOperandsfor mathematical operations. ([@marcandre][])Lint/MissingSuper. ([@marcandre][])Style/SymbolArrayandStyle/WordArray. ([@biinari][])Style/HashAsLastArrayItemwhen there are duplicate hashes in the array. ([@wcmonty][])Style/IfUnlessModifierto add parentheses when converting if-end condition inside a parenthesized method argument list. ([@dsavochkin][])Changes
<and>as comparison operators inStyle/ConditionalAssignmentcop. ([@biinari][])v0.89.0Compare Source
New features
Style/CaseEqualitycop. ([@fatkodima][])Gemspec/RequiredRubyVersioncop with check thatrequired_ruby_versionis specified. ([@fatkodima][])Lint/SelfAssignmentcop. ([@fatkodima][])Lint/DuplicateRescueExceptioncop. ([@fatkodima][])Lint/BinaryOperatorWithIdenticalOperandscop. ([@fatkodima][])Lint/UnreachableLoopcop. ([@fatkodima][])Style/OptionalBooleanParametercop. ([@fatkodima][])Lint/FloatComparisoncop. ([@fatkodima][])Lint/MissingSupercop. ([@fatkodima][])Style/ExplicitBlockArgumentcop. ([@fatkodima][])Lint/Loopcop. ([@fatkodima][])Config#for_badgeas an efficient way to get a cop's config merged with its department's. ([@marcandre][])Style/StringConcatenationcop. ([@fatkodima][])Lint/TopLevelReturnWithArgumentcop. ([@iamravitejag][])Style/GlobalStdStreamcop. ([@fatkodima][])Style/SingleArgumentDigcop. ([@volfgox][])Lint/EmptyConditionalBodycop. ([@fatkodima][])Lint/OutOfRangeRegexpRefcop. ([@sonalinavlakhe][])Bug fixes
Style/MethodCallWithArgsParenthesesEnforcedStyle: omit_parenthesesto fix invalid Ruby auto-correction. ([@gsamokovarov][])Layout/SpaceAroundMethodCallOperatorwhen usingProc#callshorthand syntax. ([@fatkodima][])Style/ConditionalAssignmentto preserve constant namespace. ([@biinari][])Style/CaseLikeIfwhen checking againstequal?andmatch?without a receiver. ([@fatkodima][])Style/HashAsLastArrayItemwhen hash is not a last array item. ([@fatkodima][])Style/RedundantConditionwhen usingraise,rescue, orandwithout argument parentheses inelse. ([@koic][])Style/RedundantRegexpEscape. ([@owst][])EnforcedStyle: hash_rocketsofStyle/HashSyntaxwithLayout/HashAlignment. ([@koic][])Style/EmptyMethod. ([@koic][])Lint/EnsureReturn. ([@marcandre][])Style/ArrayCoercionas not safe. ([@marcandre][])Style/AccessorGrouping's auto-correction to remove redundant blank lines. ([@koic][])Style/MissingRespondToMissingwhen defined method with inline access modifier. ([@koic][])Lint/SelfAssignmentwhen using or-assignment for constant. ([@koic][])Style/SingleArgumentDigwhen without a receiver. ([@koic][])Lint/IneffectiveAccessModifierwhen there isbegin...endbefore a method definition. ([@koic][])Style/IfUnlessModifierto correctly take into account code before the if condition when considering conversation to a single-line form. ([@dsavochkin][])Style/IfUnlessModifierto correctly take into account a comment on the first line when considering conversation to a single-line form. ([@dsavochkin][])Style/IfUnlessModifierto correctly take into account code on the last line after the end keyword when considering conversion to a single-line form. ([@dsavochkin][])Style/IfUnlessModifierto add parentheses when converting if-end condition inside an array or a hash to a single-line form. ([@dsavochkin][])Style/StructInheritancewhen there is a comment before class declaration. ([@koic][])Layout/FirstMethodArgumentLineBreakwhen using kwargs insuper. ([@koic][])Style/NestedParenthesizedCallsto include line continuations in whitespace for auto-correct. ([@biinari][])Changes
Style/MethodMissingSupercop is removed in favor of newLint/MissingSupercop. ([@fatkodima][])Lint/UselessComparisoncop is removed in favor of newLint/BinaryOperatorWithIdenticalOperandscop. ([@fatkodima][])Style/MultilineMethodSignature. ([@koic][])Metrics/AbcSizenow counts ||=, &&=, multiple assignments, for, yield, iterating blocks.&.now count as conditions too (unless repeated on the same variable). Default bumped from 15 to 17. Consider usingrubocop -a --disable-uncorrectableto ease transition. ([@marcandre][])Metrics/CyclomaticComplexitynot longer counts&.when repeated on the same variable. ([@marcandre][])Metrics/PerceivedComplexitynow countselseincasestatements,&.,||=,&&=and blocks known to iterate. Default bumped from 7 to 8. Consider usingrubocop -a --disable-uncorrectableto ease transition. ([@marcandre][])Lint/InterpolationCheckmarked as unsafe. ([@marcandre][])RuboCop::Cop::ParserDiagnosticmixin module. ([@koic][])v0.88.0Compare Source
New features
Lint/NonDeterministicRequireOrdercop. ([@biinari][])Style/RedundantFileExtensionInRequirecop. ([@fatkodima][])Lint/DisjunctiveAssignmentInConstructorcop. ([@fatkodima][])bin/rubocop-profileand rake tasks. ([@marcandre][])Style/ArrayCoercioncop. ([@fatkodima][])Lint/DuplicateElsifConditioncop. ([@fatkodima][])Style/CaseLikeIfcop. ([@fatkodima][])Style/HashAsLastArrayItemcop. ([@fatkodima][])Style/HashLikeCasecop. ([@fatkodima][])expect_offenseallows abbreviated offense messages. ([@marcandre][])Bug fixes
Layout/EmptyLinesAroundAccessModifierwhenendimmediately after access modifier. ([@koic][])Layout/MultilineArrayBraceLayoutwhen comment is present after last element. ([@shekhar-patil][])Layout/MultilineMethodCallBraceLayoutwhen comment is present before closing braces. ([@shekhar-patil][])Style/IfUnlessModifierbad precedence detection. ([@tejasbubane][])Style/AccessorGroupingto not register offense for accessor with comment. ([@tejasbubane][])Gemspec/RequiredRubyVersion. ([@eugeneius][])Style/PercentLiteralDelimiterswhen the source contains invalid characters. ([@eugeneius][]).rubocop.ymlfiles at all outside of the current project, unless they are personal configuration files and the project has no configuration. ([@deivid-rodriguez][])Changes
Layout/SpaceAroundMethodCallOperatorcop to make it faster. ([@fatkodima][])oftoAllowedNamesofMethodParameterNamecop. ([@AlexWayfer][])v0.87.1Compare Source
Bug fixes
Layout/MultilineBlockLayoutwhere spaces for a new line where not considered. ([@knejad][])--safe-autocorrectto--safe-auto-correct, which is compatible with RuboCop 0.86 and lower. ([@koic][])Style/BisectedAttrAccessorwhen accessors have different access modifiers. ([@fatkodima][])Style/AccessorGroupingwhen accessors have different access modifiers. ([@fatkodima][])Style/BisectedAttrAccessorwhen usingattr_readerandattr_writerwith splat arguments. ([@fatkodima][]).rubocop.ymlfrom personal folders to check for exclusions if given a custom configuration file. ([@deivid-rodriguez][])--auto-gen-configwhen running a cop who do not support auto-correction. ([@koic][])Lint/DeprecatedOpenSSLConstantauto-correction ofOpenSSL::Cipherto use lower case, as some Linux-based systems do not accept upper cased cipher names. ([@bdewater][])v0.87.0Compare Source
New features
Cop::Baseis the new recommended base class for cops. ([@marcandre][])Style/AccessorGroupingcop. ([@fatkodima][])Style/BisectedAttrAccessorcop. ([@fatkodima][])AsciiConstantsoption forNaming/AsciiIdentifiers. ([@fatkodima][])Style/RedundantAssignmentcop. ([@fatkodima][])CountAsOneoption for code length relatedMetriccops. ([@fatkodima][])Lint/InterpolationCheck. ([@koic][])Style/IfUnlessModifierOfIfUnless. ([@koic][])Lint/SafeNavigationWithEmpty. ([@koic][])Bug fixes
Lint/ParenthesesAsGroupedExpressionin when using operators or chain functions. ([@CamilleDrapier][])Style/RedundantFetchBlockwhen using withRails.cache. ([@fatkodima][])Style/RedundantFetchBlockwhen using#fetchwith empty block. ([@koic][])Style/RedundantRegexpCharacterClasswhen using[\b]. ([@owst][])Style/RedundantRegexpCharacterClasswhen using a leading escaped]. ([@owst][])Style/RedundantParentheseswith hash literal as first argument toyield. ([@karlwithak][]).rubocop.ymlfrom personal folders to check for exclusions if there's a project configuration. ([@deivid-rodriguez][])Changes
Team,Commissioner,Corrector.Cop::Cop#correctionsnot completely compatible. See Upgrade Notes. ([@marcandre][])rubocop -a / --auto-correctno longer run unsafe corrections;rubocop -A / --auto-correct-allrun both safe and unsafe corrections. Options--safe-autocorrectis deprecated. ([@marcandre][])ConsiderPunctuationsetting is set totrue. ([@marcandre][])Style/ClassVarscop now detectsclass_variable_set. ([@biinari][])::Constin various cops. ([@biinari][])v0.86.0Compare Source
New features
Style/RedundantFetchBlockcop. ([@fatkodima][])Style/StructInheritance. ([@tejasbubane][])expect_offensetemplates add variable-length whitespace with_{foo}. ([@eugeneius][])Style/MultilineTernaryOperator. ([@koic][])Style/NestedTernaryOperator. ([@koic][])Lint/ConstantResolutioncop. ([@robotdana][])Lint/RegexpAsCondition. ([@koic][])Lint/RaiseException. ([@koic][])Bug fixes
Naming/MethodName: EnforcedStyle: camelCaseand_orivariables. ([@avrusanov][])Lint::FormatParameterMismatchwhen argument contains formatting. ([@andrykonchin][])Style/RedundantRegexpEscapewith escaped delimiters. ([@owst][])Lint/FormatParameterMismatchwhen using named parameters with escaped%. ([@koic][])Style/RedundantRegexpCharacterClasswhen using interpolations. ([@owst][])Layout/EmptyLinesAroundAttributeAccessorwhen using attribute accessors inif...elsebranches. ([@koic][])Layout/MultilineBlockLayoutwhen missing newline before opening parenthesis(for block body. ([@koic][])Style/YodaConditionwhen interpolation is used on the left hand side. ([@koic][])Changes
Metrics/CyclomaticComplexitynow counts&.,||=,&&=and blocks known to iterate. Default bumped from 6 to 7. Consider usingrubocop -a --disable-uncorrectableto ease transition. ([@marcandre][])Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.