Update dependency foodcritic to v16 #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mend-5034428[bot]](https://avatars.githubusercontent.com/u/5034428?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
'~> 5.0'->'~> 16.3'Release Notes
acrmp/foodcritic (foodcritic)
v16.3.0Compare Source
Please keep in mind that Foodcritic is considered EOL. This release is being made to reduce the side of dependencies in Chef Workstation. Users of Foodcritic should migrate to Cookstyle which ships with nearly 200 Chef cookbook cops and autocorrects code.
v16.2.0Compare Source
v16.1.1Compare Source
v16.1.0Compare Source
--ast-cache-sizecommand line option. Thanks @Babarv16.0.0Compare Source
v15.1.0Compare Source
v15.0.0Compare Source
With this release of Foodcritic we are now shipping only metadata for the latest versions of each supported Chef version. Chef metadata files are getting increasingly large and this is increasing the size of Chef DK/Workstation significantly. This release ships with Chef 14.7 and 13.12 metadata and future releases will update the metadata versions without a major version bump as this should not be considered a breaking change.
v14.3.0Compare Source
v14.2.0Compare Source
v14.1.0Compare Source
v14.0.0Compare Source
v13.1.1Compare Source
v13.1.0Compare Source
Speed improvements
Foodcritic now caches some of the information on cookbooks it previously calculated repeatedly. This results in a 10X reduction in some disk reads and a 7% improvement in runtime overall.
Rule file improvements
The fetching and parsing of Foodcritic rule files (.foodcritic files) has been improved. If a non-existent file is specified on the CLI we will now fail instead of silently continuing. Additionally, if the .foodcritic file exists, but cannot be read/parsed we will also fail instead of silently continuing.
Improved file detection
Several deficiencies in how Foodcritic detected files within a cookbook have been resolved. If you use the Chef 13+ root alias files such as attributes.rb or recipe.rb these will now be detected. Additionally we will detect template files not in the default directory, or deeply nested in directories within the templates directory.
New Rules
FC116- Cookbook depends on the deprecated compat_resource cookbookFC120- Do not set the name property directly on a resourceFC122- Use the build_essential resource instead of the recipev13.0.1Compare Source
v13.0.0Compare Source
Chef 12 Support
As Chef 12 goes end of life next month this release makes several changes assuming Chef 13+:
Support for Ruby 2.2 has been removed
Chef 12 metadata files have been removed.
A new rule FC113: Resource declares deprecated use_inline_resources, which suggests a coding standard that requires Chef 13+. This rule is being introduced as use_inline_resources will begin throwing deprecation warnings in later Chef 14 releases and will eventually be removed from Chef.
Removed FC017: LWRP does not notify when updated. This is no longer applicable with Chef 13+ since inline resources are always used and notifications in resources happen automatically.
If full Chef 12 support is necessary then Foodcritic 12.2.2 is probably the best release to stick with. Keep in mind that later Foodcritic releases include rules that aid in Chef upgrades so sticking with an older release is not advised. Instead you should disable individual rules or tags that don't apply to your organization.
New/Removed Rules
Other Changes
v12.3.0Compare Source
Implemented enhancements:
v12.2.2Compare Source
Fixed bugs:
v12.2.1Compare Source
Fixed bugs:
v12.2.0Compare Source
Implemented enhancements:
Fixed bugs:
v12.1.0Compare Source
Implemented enhancements:
v12.0.1Compare Source
Fixed bugs:
v12.0.0Compare Source
Implemented enhancements:
v11.4.0Compare Source
Implemented enhancements:
v11.3.1Compare Source
Fixed bugs:
v11.3.0Compare Source
Full Changelog
Implemented enhancements:
Fixed bugs:
v11.2.0Compare Source
Full Changelog
Implemented enhancements:
opensourcetag by default to simply use of Foodcritic for non-community cookbook developers. At the time of writing this only includesFC078. To enable it again:foodcritic -t any .v11.1.0Compare Source
Full Changelog
Implemented enhancements:
FC086- Use databag helper methods to load data bag items. Tags: styleFC087- Library maps provider with deprecated Chef::Platform.set. Tags: chef13 deprecatedFC088- Prefer Mixlib::Shellout over deprecated Chef::Mixin::Command. Tags: chef13 deprecatedFC089- Prefer Mixlib::Shellout over deprecated Chef::ShellOut. Tags: chef13 deprecated--rule-fileflag to specify the path to your .foodcritic filev11.0.0Compare Source
Full Changelog
Implemented enhancements:
FC079to detect the usage of the easy_install_package resource which is deprecated in Chef 13. Tags: deprecated, chef13.FC080to detect user resources that include the supports property, which is deprecated in Chef 13. Tags: deprecated, chef13.FC081to detect a cookbook that depends on the partial_search cookbook as partial search functionality is built into Chef 12 and later. Tags: chef12.FC082to detect the usage of node.set and node.set_unless which will be removed in Chef 14. Tags: deprecated, chef14.FC083to detect execute resources that include the path property, which is deprecated in Chef 12. Tags: deprecated, chef12.FC084to detect usage of the deprecated Chef::REST class. Tags: deprecated, chef13.FC085to detect usage of new_resource.updated_by_last_action to converge resources. Tags: deprecated, chef13.declared_dependencies,supported_platforms, andword_list_valueschecks_for_chef_soloandchef_solo_search_supported?have been removed.json_file_to_hashfor loading json files as a hash.Fixed bugs:
licenseandsupermarkettag to FC078.fieldandfield_valueAPI methods to correctly recognize additional formats of data in the metdata.v10.4.1Compare Source
Full Changelog
Implemented enhancements:
Fixed bugs:
node.platform_family?in addition to the existingnode.platform?usage. This rule has also been renamed and tags updated since the use ofnode.platform?is a style issue and not a correctness issue. Bothnode.platform?andplatform?are acceptable in cookbooks.v10.4.0Compare Source
Full Changelog
Implemented enhancements:
conflictsmetadata is usedreplacesmetadata is usedopensourcetag. For example:foodcritic -t ~opensource .Fixed bugs:
v10.3.1Compare Source
Full Changelog
Implemented enhancements:
Fixed bugs:
v10.3.0Compare Source
Full Changelog
Implemented enhancements:
FC069to ensure standardized licenses are defined in metadataFC070to detect invalid platform supports in metadataFC071to ensure a LICENSE file is included with the cookbookFC072to detect attributes defined in metadataFC073to detect root alias collisions with non-root alias filesFC074to detect setting the default_action in a LWRP without using the default_action DSLFC075to detect node.save usageFC008to fail if the ChefDK generated boilerplate is includedFC024to not recommend adding amazon as an equivalent platform to Redhat as Amazon is its own platform family in Chef 13FC045to no longer fail if metadata.rb cannot be foundrake regen_regression. See the readme for additional details on running tests.v10.2.2Compare Source
Full Changelog
Implemented enhancements:
v10.2.1Compare Source
Full Changelog
Implemented enhancements:
v10.2.0Compare Source
Full Changelog
Implemented enhancements:
Fixed bugs:
--search-gems#529 (nvwls)v10.1.1Compare Source
Full Changelog
Fixed bugs:
v10.1.0Compare Source
Full Changelog
Implemented enhancements:
v10.0.0Compare Source
Full Changelog
Implemented enhancements:
v9.0.0Compare Source
Full Changelog
Implemented enhancements:
v8.2.0Compare Source
Full Changelog
Implemented enhancements:
v8.1.0Compare Source
Full Changelog
Implemented enhancements:
v8.0.0Compare Source
Full Changelog
Implemented enhancements:
v7.1.0Compare Source
Full Changelog
Implemented enhancements:
Fixed bugs:
v7.0.1Compare Source
Full Changelog
Implemented enhancements:
v7.0.0Compare Source
Full Changelog
Implemented enhancements:
v6.3.0Compare Source
Please keep in mind that Foodcritic is considered EOL. This release is being made to reduce the side of dependencies in Chef Workstation. Users of Foodcritic should migrate to Cookstyle which ships with nearly 200 Chef cookbook cops and autocorrects code.
v6.2.0Compare Source
v6.1.1Compare Source
v6.1.0Compare Source
--ast-cache-sizecommand line option. Thanks @Babarv6.0.1Compare Source
Full Changelog
Implemented enhancements:
Fixed bugs:
v6.0.0Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.