Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cprc & jsonclient: support request modifiers #781

Merged
merged 1 commit into from
Sep 18, 2024
Merged

cprc & jsonclient: support request modifiers #781

merged 1 commit into from
Sep 18, 2024

Conversation

peterjcole
Copy link
Collaborator

  • Do method now takes optional request modifier functions to be applied to the request object
  • This allows us to customise headers, e.g. allowing us to pass through the original client metadata when making service-service requests

@peterjcole peterjcole requested review from julesjcraske, a team, ei09010, brittonjg and Tatabakbak and removed request for a team September 18, 2024 08:55
@peterjcole peterjcole marked this pull request as draft September 18, 2024 08:57
@peterjcole
Copy link
Collaborator Author

peterjcole commented Sep 18, 2024 •
edited
Loading

Converted to draft while I fix the build

@peterjcole
Copy link
Collaborator Author

Build wasn't broken, unrelated flaky test

@peterjcole peterjcole marked this pull request as ready for review September 18, 2024 09:16
@peterjcole peterjcole merged commit c70c4bd into master Sep 18, 2024
3 checks passed
@peterjcole peterjcole deleted the crpc-support-request-modifiers branch September 18, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julesjcraske julesjcraske julesjcraske approved these changes

@ei09010 ei09010 Awaiting requested review from ei09010 ei09010 was automatically assigned from cuvva/product-on-demand

@brittonjg brittonjg Awaiting requested review from brittonjg brittonjg was automatically assigned from cuvva/product-on-demand

@Tatabakbak Tatabakbak Awaiting requested review from Tatabakbak Tatabakbak was automatically assigned from cuvva/product-on-demand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterjcole @julesjcraske