Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR Template to Include New Description/Overview Guidelines #11

Merged
merged 4 commits into from
Oct 19, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,25 @@
### Description
### Stakeholder Overview

<!--
Describe the relevant motivation and context for this change.
Please include a summary of the change as well as the issue that is fixed.
This section should provide a brief overview of the changes and the motivation for the changes in a
manner friendly to non-technical people and to technical people who don't know the context or are not
subject matter experts on the system or update being made. Consider the logical need for the change,
as well as the logical effect of the change, particularly as any end-users would experience it.
ShaunaGordon marked this conversation as resolved.
Show resolved Hide resolved

Good example:
IHP is in the process of updating the way carts get built. This is the core cart creation
logic that sorts and groups orders into carts. With the upcoming change for the UI, users will
be able to skip the Press Staging Queue and create a cart based on the flash count for the
printer they are selecting for.

Good example:
We are currently sending all pageViewTags as custom events to fullstory which results in Fullstory
throttling Custom Events for our accounts. This prevents us from using custom events for more legitimate
users (e.g. custom event to track when a user is in test group)
ShaunaGordon marked this conversation as resolved.
Show resolved Hide resolved
This change is going to help Swag Management to identify sessions of users in Swag Management test group.
ShaunaGordon marked this conversation as resolved.
Show resolved Hide resolved

Bad example:
change ingress
-->

### Changes
Expand Down