Refactor subgraph network connector #298
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… chain - Updated the `query` function and subgraph URLs to use separate API endpoints for Mainnet, Arbitrum, and Optimism instead of a unified API, which due to TheGraph cancelling it's hosted services is now depreciated. - Added new constants for Mainnet, Arbitrum, and Optimism subgraph URLs. Note an API Key is now required and should be defined in the .env file. Additional markets can be added by using the same logic: https://thegraph.com/explorer?chain=arbitrum-one&search=volume%2520curve - Modified the `_get_subgraph_url` function to return the appropriate URL based on the specified chain and environment. - Adjusted the `convex` function to utilize the updated `_get_subgraph_url` logic. - Ensured minimal changes to other parts of the code to maintain existing functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain what you did and why, ser.
queryfunction and subgraph URLs to use separate API endpoints for Mainnet, Arbitrum, and Optimism instead of a unified API, which due to TheGraph cancelling its hosted services is now depreciated._get_subgraph_urlfunction to return the appropriate URL based on the specified chain and environment.convexfunction to utilize the updated_get_subgraph_urllogic.Hygiene checklist
(modules, public functions, classes, and public methods)
and descriptive commit messages following Tim Pope's style
Cute Animal Picture