Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tricrypto one-coin withdrawal tests #284

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Fix tricrypto one-coin withdrawal tests #284

merged 1 commit into from
Nov 10, 2023

Conversation

allt0ld
Copy link
Collaborator

@allt0ld allt0ld commented Nov 10, 2023

Description

Small fixes for test_remove_liquidity_one_coin and test_calc_withdraw_one_coin in test_tricrypto.py

Hygiene checklist

  • Changelog entry
  • Everything public has a Numpy-style docstring
    (modules, public functions, classes, and public methods)
  • Commit history is cleaned-up with minor changes squashed together
    and descriptive commit messages following Tim Pope's style

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@github-actions GitHub Actions
Copy link
Contributor

Coverage report

The coverage rate went from 78.2% to 78.36% ⬆️
The branch rate is 64%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

@chanhosuh chanhosuh self-requested a review November 10, 2023 20:19
@chanhosuh chanhosuh merged commit d794f51 into main Nov 10, 2023
15 checks passed
@chanhosuh chanhosuh deleted the test-fix branch November 10, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanhosuh chanhosuh chanhosuh approved these changes

Assignees

@allt0ld allt0ld

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allt0ld @chanhosuh