[CSR-1806] feat: allow template for the previous-ci-build-id input #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vCaisim
force-pushed
the
feat/prev-ci-build-id-template
branch
from
83ba956 to
066f03c
Compare
fix: update dist fix: format workflow fix: lint fix: use lodash .template to parse previous-ci-build-id input value fix: lint fix: lint fix: unit-tests.yml
vCaisim
force-pushed
the
feat/prev-ci-build-id-template
branch
from
066f03c to
0fc6710
Compare
twk3
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
previous-ci-build-idinput value as a template (using lodash .template)The
previous-ci-build-idaction input is passed tocurrents api get-run's command--ci-build-idoption and is used to find the previous run information.Manual Tests:
Runs:
first - https://app.currents.dev/run/99298a1fa4111571
retry - https://app.currents.dev/run/94f2219906ed5297
Tested using a copy of the
playwright-last-failedaction with the changes applied - https://github.com/vCaisim/playwright-last-failedThe workflow with template value for
previous-ci-build-id- https://github.com/vCaisim/playwright-gh-actions-demo/blob/b56714a0abfa154bc8a7cbb030d33d1ef46fa9fa/.github/workflows/rerun-action-or8n.yml#L44The actions:
https://github.com/vCaisim/playwright-gh-actions-demo/actions/runs/12069399850