chore: fixing gh linter

wip wip wip wip wip wip wip wip
currents-dev · Nov 6, 2024 · 1e6779f · 1e6779f
1 parent 6df1406
commit 1e6779f
Show file tree

Hide file tree

Showing 6 changed files with 128 additions and 97 deletions.
diff --git a/.eslintignore b/.eslintignore
diff --git a/.github/linters/.eslintrc.yml b/.github/linters/.eslintrc.yml
diff --git a/.github/linters/eslint.config.mjs b/.github/linters/eslint.config.mjs
@@ -0,0 +1,114 @@
+import jest from 'eslint-plugin-jest'
+import typescriptEslint from '@typescript-eslint/eslint-plugin'
+import globals from 'globals'
+import tsParser from '@typescript-eslint/parser'
+import path from 'node:path'
+import { fileURLToPath } from 'node:url'
+import js from '@eslint/js'
+import { FlatCompat } from '@eslint/eslintrc'
+
+const __filename = fileURLToPath(import.meta.url)
+const __dirname = path.dirname(__filename)
+const compat = new FlatCompat({
+  baseDirectory: __dirname,
+  recommendedConfig: js.configs.recommended,
+  allConfig: js.configs.all
+})
+
+export default [
+  {
+    ignores: [
+      '!**/.*',
+      '**/node_modules/.*',
+      '**/dist/.*',
+      'dist/**/*',
+      '**/lib/.*',
+      '**/coverage/.*',
+      '**/*.json',
+      '**/eslint.config.mjs'
+    ]
+  },
+  ...compat.extends(
+    'eslint:recommended',
+    'plugin:@typescript-eslint/eslint-recommended',
+    'plugin:@typescript-eslint/recommended',
+    'plugin:jest/recommended'
+  ),
+  {
+    plugins: {
+      jest,
+      '@typescript-eslint': typescriptEslint
+    },
+
+    languageOptions: {
+      globals: {
+        ...globals.node,
+        ...globals.jest,
+        Atomics: 'readonly',
+        SharedArrayBuffer: 'readonly'
+      },
+
+      parser: tsParser,
+      ecmaVersion: 2023,
+      sourceType: 'module',
+
+      parserOptions: {
+        project: ['./.github/linters/tsconfig.json', './tsconfig.json']
+      }
+    },
+
+    rules: {
+      camelcase: 'off',
+      'eslint-comments/no-use': 'off',
+      'eslint-comments/no-unused-disable': 'off',
+      'i18n-text/no-en': 'off',
+      'import/no-namespace': 'off',
+      'no-console': 'off',
+      'no-unused-vars': 'off',
+      semi: 'off',
+      '@typescript-eslint/array-type': 'error',
+      '@typescript-eslint/await-thenable': 'error',
+      '@typescript-eslint/ban-ts-comment': 'error',
+      '@typescript-eslint/consistent-type-assertions': 'error',
+
+      '@typescript-eslint/explicit-member-accessibility': [
+        'error',
+        {
+          accessibility: 'no-public'
+        }
+      ],
+
+      '@typescript-eslint/explicit-function-return-type': [
+        'error',
+        {
+          allowExpressions: true
+        }
+      ],
+
+      '@typescript-eslint/no-array-constructor': 'error',
+      '@typescript-eslint/no-empty-interface': 'error',
+      '@typescript-eslint/no-explicit-any': 'error',
+      '@typescript-eslint/no-extraneous-class': 'error',
+      '@typescript-eslint/no-for-in-array': 'error',
+      '@typescript-eslint/no-inferrable-types': 'error',
+      '@typescript-eslint/no-misused-new': 'error',
+      '@typescript-eslint/no-namespace': 'error',
+      '@typescript-eslint/no-non-null-assertion': 'warn',
+      '@typescript-eslint/no-require-imports': 'error',
+      '@typescript-eslint/no-unnecessary-qualifier': 'error',
+      '@typescript-eslint/no-unnecessary-type-assertion': 'error',
+      '@typescript-eslint/no-unused-vars': 'error',
+      '@typescript-eslint/no-useless-constructor': 'error',
+      '@typescript-eslint/no-var-requires': 'error',
+      '@typescript-eslint/prefer-for-of': 'warn',
+      '@typescript-eslint/prefer-function-type': 'warn',
+      '@typescript-eslint/prefer-includes': 'error',
+      '@typescript-eslint/prefer-string-starts-ends-with': 'error',
+      '@typescript-eslint/promise-function-async': 'error',
+      '@typescript-eslint/require-array-sort-compare': 'error',
+      '@typescript-eslint/restrict-plus-operands': 'error',
+      '@typescript-eslint/space-before-function-paren': 'off',
+      '@typescript-eslint/unbound-method': 'error'
+    }
+  }
+]
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -56,9 +56,7 @@ jobs:
       - name: Test Local Action
         id: test-action
         uses: ./
-        with:
-          milliseconds: 2000
 
-      - name: Print Output
-        id: output
-        run: echo "${{ steps.test-action.outputs.time }}"
+      # - name: Print Output
+      #   id: output
+      #   run: echo "${{ steps.test-action.outputs }}"
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -3,12 +3,15 @@ name: Test Action
 on:
   workflow_dispatch:
 
+permissions:
+  contents: read
+
 jobs:
   test-action-sharding:
     strategy:
-    fail-fast: false
-    matrix:
-      shard: [1, 2]
+      fail-fast: false
+      matrix:
+        shard: [1, 2]
     runs-on: ubuntu-latest
     env:
       CURRENTS_RECORD_KEY: ${{ secrets.CURRENTS_RECORD_KEY }}
@@ -27,7 +30,6 @@ jobs:
         run: |
           echo "Key: ${{ env.CURRENTS_RECORD_KEY }}"
           echo "Matrix Index: ${{ matrix.shard }}"
-          echo "Matrix Total: ${{ matrix.job-total }}"
 
       - name: Run My Action (Sharding)
         id: sharding_action
@@ -36,7 +38,7 @@ jobs:
           debug: true
           pw-output-dir: basic/test-results
           matrix-index: ${{ matrix.shard }}
-          matrix-total: ${{ matrix.job-total }}
+          # matrix-total: ${{ matrix.shard.length }}
 
       - name: Verify Action Output (Sharding)
         run: |
@@ -47,13 +49,12 @@ jobs:
       fail-fast: false
       matrix:
         shard: [1, 2]
-      runs-on: ubuntu-latest
+    runs-on: ubuntu-latest
     env:
       CURRENTS_PROJECT_ID: ${{ secrets.CURRENTS_PROJECT_ID }}
       CURRENTS_API_KEY: ${{ secrets.CURRENTS_API_KEY }}
       CURRENTS_REST_API_URL: ${{ secrets.CURRENTS_REST_API_URL }}
 
-    runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4

diff --git a/package.json b/package.json
@@ -25,16 +25,16 @@
   },
   "scripts": {
     "bundle": "npm run format:write && npm run package",
-    "ci-test": "npx jest",
+    "ci-test": "npx jest --passWithNoTests",
     "coverage": "npx make-coverage-badge --output-path ./badges/coverage.svg",
     "format:write": "npx prettier --write .",
     "format:check": "npx prettier --check .",
-    "lint": "npx eslint . -c ./.github/linters/.eslintrc.yml",
+    "lint": "npx eslint . -c ./.github/linters/eslint.config.mjs",
     "package:index": "ncc build src/index.ts -o dist/index && mv dist/index/index.js dist/ && rm -rf dist/index",
     "package:post": "ncc build src/post.ts -o dist/post && mv dist/post/index.js dist/post/post.js && mv dist/post/post.js dist/post.js && rm -rf dist/post",
     "package": "npm run package:index && npm run package:post",
     "package:watch": "npm run package -- --watch",
-    "test": "npx jest",
+    "test": "npx jest --passWithNoTests",
     "all": "npm run format:write && npm run lint && npm run test && npm run coverage && npm run package"
   },
   "license": "MIT",