Skip to content

Commit

Permalink
feature: implement ci timeout pass flag
Browse files Browse the repository at this point in the history
  • Loading branch information
miguelangarano committed Sep 27, 2023
1 parent 76d048b commit 19ccd7b
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 12 deletions.
7 changes: 2 additions & 5 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@


# [2.0.0-beta.1](https://github.com/currents-dev/cypress-cloud/compare/v2.0.0-beta.0...v2.0.0-beta.1) (2023-09-22)


### Bug Fixes

* debugging fixes ([d502b12](https://github.com/currents-dev/cypress-cloud/commit/d502b121b4a5bb85921fa26b6b04a12274be3b19))
- debugging fixes ([d502b12](https://github.com/currents-dev/cypress-cloud/commit/d502b121b4a5bb85921fa26b6b04a12274be3b19))

# [2.0.0-beta.0](https://github.com/currents-dev/cypress-cloud/compare/v1.10.0-beta.1...v2.0.0-beta.0) (2023-09-19)

Expand Down Expand Up @@ -339,4 +336,4 @@
- implement generic http client with retries ([a9711bd](https://github.com/currents-dev/cypress-cloud/commit/a9711bde1fbb2cd37dbc8979593159d183bfa866))
- improve setup steps ([9bf16fe](https://github.com/currents-dev/cypress-cloud/commit/9bf16fe5f3773db4aa2f169515303ea6d0973da6))
- separate stdout per spec file ([a9d01c3](https://github.com/currents-dev/cypress-cloud/commit/a9d01c349cbfe140a568a452b0e7163e6d27f2db))
- setup github actions ([d439f56](https://github.com/currents-dev/cypress-cloud/commit/d439f5660698177087fcc2e7a61c64ea263816f6))
- setup github actions ([d439f56](https://github.com/currents-dev/cypress-cloud/commit/d439f5660698177087fcc2e7a61c64ea263816f6))
3 changes: 2 additions & 1 deletion packages/cypress-cloud/bin/lib/program.ts
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,8 @@ ${getLegalNotice()}
)
.default(undefined)
.argParser((i) => (i === "false" ? false : true))
).addOption(
)
.addOption(
new Option(
`--ci-timeout-pass [bool]`,
`Enable ci runner to pass/fail but no error even if the run timed out`
Expand Down
4 changes: 2 additions & 2 deletions packages/cypress-cloud/lib/bootstrap/serializer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ function getCypressCLIParams(
const testingType =
result.testingType === "component"
? {
component: true,
}
component: true,
}
: {};
return {
..._.omit(result, "testingType", "ciTimeoutPass"),
Expand Down
7 changes: 4 additions & 3 deletions packages/cypress-cloud/lib/run.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export async function run(params: CurrentsRunParameters = {}) {
batchSize,
autoCancelAfterFailures,
experimentalCoverageRecording,
ciTimeoutPass
ciTimeoutPass,
} = validatedParams;

const config = await getMergedConfig(validatedParams);
Expand All @@ -88,7 +88,8 @@ export async function run(params: CurrentsRunParameters = {}) {
info(`Cypress version: ${dim(_cypressVersion)}`);
info("Discovered %d spec files", specs.length);
info(
`Tags: ${tag.length > 0 ? tag.join(",") : false}; Group: ${group ?? false
`Tags: ${tag.length > 0 ? tag.join(",") : false}; Group: ${
group ?? false
}; Parallel: ${parallel ?? false}; Batch Size: ${batchSize}`
);
info("Connecting to cloud orchestration service...");
Expand All @@ -109,7 +110,7 @@ export async function run(params: CurrentsRunParameters = {}) {
batchSize,
autoCancelAfterFailures,
coverageEnabled: experimentalCoverageRecording,
ciTimeoutPass
ciTimeoutPass,
});

setRunId(run.runId);
Expand Down
2 changes: 1 addition & 1 deletion packages/cypress-cloud/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ export type CurrentsRunParameters = StrippedCypressModuleAPIOptions & {

// User-facing `run` interface
// We can resolve the projectId and recordKey from different sources, so we can't really enforce them via the type definition
export interface CurrentsRunAPI extends CurrentsRunParameters { }
export interface CurrentsRunAPI extends CurrentsRunParameters {}

// Params after validation and resolution
export interface ValidatedCurrentsParameters extends CurrentsRunParameters {
Expand Down

0 comments on commit 19ccd7b

Please sign in to comment.