Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix backport ready for PyGithub 2 #40

Merged
merged 1 commit into from
Sep 4, 2023
Merged

fix backport ready for PyGithub 2 #40

merged 1 commit into from
Sep 4, 2023

Conversation

kmaehashi
Copy link
Member

https://github.com/PyGithub/PyGithub/releases/tag/v1.59.0

This release introduces new way of authentication. All authentication-related arguments github.Github(login_or_token=…, password=…, jwt=…, app_auth=…) and github.GithubIntegration(integration_id=…, private_key=…, jwt_expiry=…, jwt_issued_at=…, jwt_algorithm=…) are replaced by a single auth=… argument. Module github.Auth provides classes for all supported ways of authentication: Login, Token, AppAuth, AppAuthToken, AppInstallationAuth, AppUserAuth. Old arguments are deprecated but continue to work. They are scheduled for removal for version 2.0 release.

@@ -90,15 +90,15 @@ def git(args: list[str], cd: Optional[str] = None) -> None:
print('')


class App(object):
class App:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is just a cleanup, unrelated to PyGithub :)

Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asi1024 asi1024 merged commit 580d8c5 into main Sep 4, 2023
2 checks passed
@asi1024 asi1024 deleted the fix-backport-auth branch September 4, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants