Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update age normalization method in frequency based model evaluator #7

Open
xj2193 opened this issue Feb 17, 2023 · 0 comments
Open
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@xj2193
Copy link
Contributor

xj2193 commented Feb 17, 2023

The current normalization method for age is applied on the entire dataset before splitting up which might cause age information leakage for the future so it isn't aligned with the best practice. The method needs to be updated to make the evaluations fair across train/test/validation sets.

For frequency baseline models, we need to "STOP" normalizing age in the corresponding evaluators where we process the data for evaluation.

https://github.com/cumc-dbmi/cehr-bert/blob/8be39f18cfbfba0f3905110bdf6a2e0fa289ff08/evaluations/model_evaluators.py#L406

@xj2193 xj2193 self-assigned this Feb 17, 2023
@xj2193 xj2193 added bug Something isn't working enhancement New feature or request labels Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant