Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hugo: show background color on all inline code blocks #486

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anne-usmedia
Copy link
Collaborator

  • Removed the code that only adds a background to inline code when inside p or list
  • Give code element a transparent background when inside of pre element.

Test:

  • Add inline code to some steps and see if they have a background color:
    /examples/shortcodes/step/
  • Check all other uses for code, not only inline, e.g.:
    • /examples/basic/code-block/
    • /examples/shortcodes/code-tabs/

Fixes
cue-lang/cue#3003
and
cue-lang/cue#3498

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for cue ready!

Name Link
🔨 Latest commit 79abee8
🔍 Latest deploy log https://app.netlify.com/sites/cue/deploys/6762c2ee58fcc50008995cbe
😎 Deploy Preview https://deploy-preview-486--cue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

* Removed the code that only adds a background
to inline code when inside p or list
* Give code element a transparent background
when inside of pre element.

Test:
* Add inline code to some steps and see if they
have a background color:
/examples/shortcodes/step/
* Check all other uses for code,
not only inline, e.g.:
    * /examples/basic/code-block/
    * /examples/shortcodes/code-tabs/

Fixes
cue-lang/cue#3003
and
cue-lang/cue#3498

Signed-off-by: Anne van Gorkom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant