encoding/gocode: use many fewer go/packages.LoadMode bits

We just need a package's name and type information. We don't need its syntax nor do we need to load dependencies, both of which multiply the cost of go/packages. `go generate` for encoding/gocode drops from ~1.55s to ~0.45s on my laptop after this change, which should help CI. Currently, its `go generate ./...` step with a warm Go cache is one of the slowest, clocking in at 12s. Slow generation steps are particularly harmful as they are sequential. Signed-off-by: Daniel Martí <[email protected]> Change-Id: I06cc023bedfee5cadf5313cf001b35bce9f41af3 Dispatch-Trailer: {"type":"trybot","CL":1201336,"patchset":1,"ref":"refs/changes/36/1201336/1","targetBranch":"master"}
cue-lang · Sep 16, 2024 · b3301b7 · b3301b7
1 parent 040858d
commit b3301b7
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/encoding/gocode/generator.go b/encoding/gocode/generator.go
@@ -109,7 +109,7 @@ func Generate(pkgPath string, inst cue.InstanceOrValue, c *Config) (b []byte, er
 	pkgName := inst.Value().BuildInstance().PkgName
 	if pkgPath != "" {
 		loadCfg := &packages.Config{
-			Mode: packages.NeedName | packages.NeedFiles | packages.NeedCompiledGoFiles | packages.NeedImports | packages.NeedTypes | packages.NeedTypesSizes | packages.NeedSyntax | packages.NeedTypesInfo | packages.NeedDeps,
+			Mode: packages.NeedName | packages.NeedTypes | packages.NeedTypesInfo,
 		}
 		pkgs, err := packages.Load(loadCfg, pkgPath)
 		if err != nil {