pkg/tool/file: use 0o777 as the default Mkdir permissions

file.Create and file.Append already default to 0o666 rather than 0o644 to rely on the user's umask, but file.Mkdir was inconsistent in using 0o755 rather than 0o777. Signed-off-by: Daniel Martí <[email protected]> Change-Id: I8f11fcc7bbd27bf34f78b41a3242af62f43cac07 Dispatch-Trailer: {"type":"trybot","CL":1200570,"patchset":2,"ref":"refs/changes/70/1200570/2","targetBranch":"master"}
cue-lang · Sep 3, 2024 · 6d44ade · 6d44ade
1 parent 2da59f2
commit 6d44ade
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/pkg/tool/file/file.cue b/pkg/tool/file/file.cue
@@ -89,7 +89,7 @@ Mkdir: {
 	createParents: bool | *false
 
 	// Directory mode and permission bits (before umask).
-	permissions: int | *0o755
+	permissions: int | *0o777
 }
 
 // MkdirAll creates a directory at the specified path along with any necessary

diff --git a/pkg/tool/file/pkg.go b/pkg/tool/file/pkg.go
diff --git a/tools/flow/testdata/issue2416a.txtar b/tools/flow/testdata/issue2416a.txtar
@@ -75,7 +75,7 @@ graph TD
 	path:          "output"
 	createParents: true
 	stdout:        "foo"
-	permissions:   493
+	permissions:   511
 }
 -- out/run-v3/t2/value --
 {
@@ -84,7 +84,7 @@ graph TD
 		path:          "output"
 		createParents: true
 		stdout:        "foo"
-		permissions:   493
+		permissions:   511
 	}
 	$id:         "tool/file.Create"
 	filename:    "output/dns-records.zone"
@@ -107,7 +107,7 @@ diff old new
  		path:          "output"
 @@ -7,6 +6,7 @@
  		stdout:        "foo"
- 		permissions:   493
+ 		permissions:   511
  	}
 +	$id:         "tool/file.Create"
  	filename:    "output/dns-records.zone"
@@ -139,7 +139,7 @@ graph TD
 		path:          "output"
 		createParents: true
 		stdout:        "foo"
-		permissions:   493
+		permissions:   511
 	}
 	filename:    "output/dns-records.zone"
 	permissions: 438