Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover basic and colored output regressions with unit tests #302

Merged
merged 27 commits into from
Oct 16, 2023
Merged

Cover basic and colored output regressions with unit tests #302

merged 27 commits into from
Oct 16, 2023

Conversation

50U10FCA7
Copy link
Contributor

@50U10FCA7 50U10FCA7 commented Sep 13, 2023 •
edited
Loading

Resolves #299

writer::Basic seems to be broken when outputting in color mode.

writer::Basic::lines_to_clear counts more lines than need be cleared. Duplication of #300

Cover basic and colored output with unit tests.

Additionally:

@tyranron tyranron added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes labels Sep 14, 2023
@tyranron tyranron added this to the 0.21.0 milestone Sep 14, 2023
@50U10FCA7 50U10FCA7 marked this pull request as draft September 14, 2023 11:48
@50U10FCA7 50U10FCA7 changed the title Fix colored output Cover colored output with unit tests Sep 14, 2023
@50U10FCA7 50U10FCA7 changed the title Cover colored output with unit tests Cover basic and colored output regressions with unit tests Sep 21, 2023
@50U10FCA7 50U10FCA7 marked this pull request as ready for review September 21, 2023 15:07
@tyranron tyranron mentioned this pull request Sep 27, 2023
Merged
@tyranron tyranron added k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::testing Related to testing and/or automated tests labels Oct 16, 2023
tyranron
tyranron approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@50U10FCA7 thanks!

@tyranron tyranron merged commit 169fcff into cucumber-rs:main Oct 16, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@50U10FCA7 50U10FCA7

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::testing Related to testing and/or automated tests k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.20.1
Development

Successfully merging this pull request may close these issues.

Neither feature nor scenario headings are printed after updating to 0.20
2 participants
@50U10FCA7 @tyranron