Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand Docstrings and names in Scenario Outline (#172) #178

Merged
merged 4 commits into from
Dec 7, 2021
Merged

Expand Docstrings and names in Scenario Outline (#172) #178

merged 4 commits into from
Dec 7, 2021

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Dec 7, 2021 •
edited by tyranron
Loading

Resolves #172

Synopsis

For now, Docstrings and names aren't replaced in Scenario Outline.

Solution

Replace them with same regex, as tables. For more info see test spec.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv added the bug Something isn't working label Dec 7, 2021
@ilslv ilslv added this to the 0.11 milestone Dec 7, 2021
@ilslv ilslv self-assigned this Dec 7, 2021
@ilslv ilslv marked this pull request as ready for review December 7, 2021 05:31
@ilslv ilslv changed the title Draft: Expand Docstrings in Scenario Outline Expand Docstrings in Scenario Outline Dec 7, 2021
@ilslv ilslv requested a review from tyranron December 7, 2021 05:31
@ilslv ilslv changed the title Expand Docstrings in Scenario Outline Expand Docstrings and names in Scenario Outline Dec 7, 2021
@ilslv ilslv changed the title Expand Docstrings and names in Scenario Outline Expand Docstrings and names in Scenario Outline (#172) Dec 7, 2021
@ilslv
Copy link
Member Author

ilslv commented Dec 7, 2021 •
edited by tyranron
Loading

FCM

Expand docstrings and names in `Scenario Outline` (#178, #172)

tyranron
tyranron approved these changes Dec 7, 2021
View reviewed changes
codegen/src/attribute.rs
// TODO: Panic here, once `const_panic` is stabilized.
// https://github.com/rust-lang/rust/pull/89508
#[automatically_derived]
const _: () = ::std::assert!(
Copy link
Member

@tyranron tyranron Dec 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilslv by removing const context, don't we move this assertion to runtime?

The whole regex is used insize Lazy. I'd opt for having explicit const context here for avoiding possible accidentials.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyranron nice point, const should be left 👍

@tyranron tyranron added enhancement Improvement of existing features or bugfix and removed bug Something isn't working labels Dec 7, 2021
@tyranron tyranron merged commit 56ebadc into main Dec 7, 2021
@tyranron tyranron deleted the 172-scenario-outline-docstring-expansion branch December 7, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ilslv ilslv

Labels
enhancement Improvement of existing features or bugfix
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

Allow scenario expansion for docstrings
2 participants
@ilslv @tyranron