Custom Parameters in Cucumber Expressions (#124) #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FCM |
ilslv
changed the title
tyranron
approved these changes
Nov 29, 2021
Cargo.toml
Outdated
| @@ -40,7 +40,7 @@ timestamps = [] | |||
| async-trait = "0.1.40" | |||
| atty = "0.2.14" | |||
| console = "0.15" | |||
| derive_more = { version = "0.99.16", features = ["as_ref", "deref", "deref_mut", "display", "error", "from", "into"], default_features = false } | |||
| derive_more = { version = "0.99.16", features = ["as_ref", "deref", "deref_mut", "display", "error", "from", "from_str", "into"], default_features = false } | |||
There was a problem hiding this comment.
If we don't use derive(FromStr) in src/, we shouldn't introduce it here, but rather in [dev-dependencies].
| @@ -54,6 +54,7 @@ structopt = "0.3.25" | |||
|
|
|||
| # "macros" feature dependencies | |||
| cucumber-codegen = { version = "0.11.0-dev", path = "./codegen", optional = true } | |||
| cucumber-expressions = { version = "0.1.0", features = ["into-regex"], optional = true } | |||
There was a problem hiding this comment.
Same here, we don't need "into-regex" feature in cucumber crate directly, so we shouldn't require it.
codegen/src/parameter.rs
Outdated
| name: Option<syn::LitStr>, | ||
| } | ||
|
|
||
| /// Representation of a struct implementing `Parameter`, used for code |
There was a problem hiding this comment.
Why only struct? Any type satisfying the requirements will be valid here.
codegen/src/attribute.rs
Outdated
| Provider, | ||
| ) | ||
| .unwrap_or_else(|e| { | ||
| panic!("Cucumber expression failed: {}", e) |
There was a problem hiding this comment.
As it should never fail, then we may use just unwrap(), as we do with regular expressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #124
Synopsis
For now there is only support for default parameters in cucumber expressions.
Solution
Implement
Parameterderive macro and add const asserts to avoid runtime panics.Checklist
Draft:prefixDraft:prefix is removed