Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Serial Scenarios from the front of the queue in runner::Basic #146

Merged
merged 5 commits into from
Oct 29, 2021

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Oct 28, 2021

Synopsis

If Feature has Serial Scenarios, both them and Concurrent ones are inserted in front. But when we get them, Concurrent Scenarios are drained from the front, while Serial Scenarios are popped from the back.
This may lead console output hanging because of executing wrong Concurrent Scenarios.

Solution

Get Serial Scenarios from the front, same as Concurrent.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

This PR is nominated at RU RustCon Contest

@ilslv ilslv added the enhancement Improvement of existing features or bugfix label Oct 28, 2021
@ilslv ilslv self-assigned this Oct 28, 2021
@ilslv ilslv changed the title Change Feature inserting algorithm in runner::Basic Get Serial Scenarios from the front of the queue Oct 29, 2021
@ilslv ilslv changed the title Get Serial Scenarios from the front of the queue Get Serial Scenarios from the front of the queue in runner::Basic Oct 29, 2021
@ilslv
Copy link
Member Author

ilslv commented Oct 29, 2021

FCM

Get `Serial` `Scenario`s from the front of the queue in `runner::Basic` (#146)

@ilslv ilslv added this to the 0.10.1 milestone Oct 29, 2021
@ilslv ilslv requested a review from tyranron October 29, 2021 07:07
@tyranron tyranron added the bug Something isn't working label Oct 29, 2021
@tyranron tyranron marked this pull request as ready for review October 29, 2021 08:26
@tyranron tyranron merged commit e640fbb into main Oct 29, 2021
@tyranron tyranron deleted the change-feature-inserting-algorithm branch October 29, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Improvement of existing features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants