Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neither feature nor scenario headings are printed after updating to 0.20 #299

Closed
serzhshakur opened this issue Aug 16, 2023 · 5 comments · Fixed by #302
Closed

Neither feature nor scenario headings are printed after updating to 0.20 #299

serzhshakur opened this issue Aug 16, 2023 · 5 comments · Fixed by #302
Labels
bug Something isn't working k::UI/UX UI (user interface) and UX (user experience) changes
Milestone
0.20.1

Comments

@serzhshakur
Copy link

After updating to cucumber-rs 0.20 neither feature, nor scenario, nor rule headings are printed to a console when running tests with colored output. See the comparison below:

  • with cucumber-rs 0.19
    image

  • with cucumber-rs 0.20
    image

However heading are printed when running tests with --color=never

image

You can check this repo for the reference
@serzhshakur
Copy link
Author

Probably related to #282

@zohnannor
Copy link

I've bisected the commits between https://github.com/cucumber-rs/cucumber/releases/tag/v0.20.0 and https://github.com/cucumber-rs/cucumber/releases/tag/v0.19.0. This and this are changes (introduced in #258) that seem to cause the new, wrong behavior. As I don't know the exact reasoning behind those changes, I'll ping @ilslv for elaboration/investigation 🙂

@tyranron tyranron added bug Something isn't working k::UI/UX UI (user interface) and UX (user experience) changes labels Aug 17, 2023
@tyranron tyranron added this to the 0.21.0 milestone Aug 17, 2023
@Daanoz Daanoz mentioned this issue Aug 24, 2023
Merged
tyranron pushed a commit that referenced this issue Sep 14, 2023
@Daanoz
Fix missing feature and scenario headers in interactive terminal mode (…
62579b0 
…#300, #299)
@tyranron tyranron mentioned this issue Sep 14, 2023
Merged
@berkes
Copy link

berkes commented Sep 19, 2023

Probably related: tracing output gets overwritten by this same "bug" it seems. Disabling color keeps the tracing output, enabling color overwrites it with blank lines.

tyranron pushed a commit that referenced this issue Oct 16, 2023
@50U10FCA7
Cover basic and colored output regressions with unit tests (#302, #299)
169fcff 
Additionally:
- use deterministic order of possible matches in `AmbiguousMatchError`
- reduce count of cursor moves in `writer::out::WriteStrExt::clear_last_lines()`
- unify code style of lines accessing `writer::Basic`

Co-authored-by: 50U10FCA7 <[email protected]>
@tyranron
Copy link
Member

@serzhshakur @berkes released as 0.20.1.

@serzhshakur
Copy link
Author

Great, thank you, works as expected now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.20.1
Development

Successfully merging a pull request may close this issue.

Cover basic and colored output regressions with unit tests 50U10FCA7/cucumber
4 participants
@berkes @tyranron @serzhshakur @zohnannor