Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Target force release #27

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix: Target force release #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
223 changes: 214 additions & 9 deletions ...ems/[systemSlug]/deployments/[deploymentSlug]/releases/[versionId]/TargetReleaseTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,216 @@
"use client";

import { Fragment } from "react";
import React, { Fragment, useState } from "react";
import { useRouter } from "next/navigation";
import { capitalCase } from "change-case";
import _ from "lodash";
import { TbLoader2 } from "react-icons/tb";
import { TbAlertTriangle, TbDots, TbLoader2 } from "react-icons/tb";

import { cn } from "@ctrlplane/ui";
import {
AlertDialog,
AlertDialogAction,
AlertDialogCancel,
AlertDialogContent,
AlertDialogDescription,
AlertDialogFooter,
AlertDialogHeader,
AlertDialogTitle,
AlertDialogTrigger,
} from "@ctrlplane/ui/alert-dialog";
import { Badge } from "@ctrlplane/ui/badge";
import { Button, buttonVariants } from "@ctrlplane/ui/button";
import {
DropdownMenu,
DropdownMenuContent,
DropdownMenuItem,
DropdownMenuTrigger,
} from "@ctrlplane/ui/dropdown-menu";
import { Table, TableBody, TableCell, TableRow } from "@ctrlplane/ui/table";
import {
Tooltip,
TooltipContent,
TooltipProvider,
TooltipTrigger,
} from "@ctrlplane/ui/tooltip";

import { api } from "~/trpc/react";
import { JobTableStatusIcon } from "../../../../../../_components/JobTableStatusIcon";

const ForceReleaseTargetDialog: React.FC<{
release: { id: string; version: string };
target: { id: string; name: string };
deploymentName: string;
environmentId: string;
onClose: () => void;
children: React.ReactNode;
}> = ({
release,
deploymentName,
target,
environmentId,
onClose,
children,
}) => {
const forceRelease = api.release.deploy.toTarget.useMutation();
const router = useRouter();
const [open, setOpen] = useState(false);

return (
<AlertDialog open={open} onOpenChange={setOpen}>
<AlertDialogTrigger asChild>{children}</AlertDialogTrigger>
<AlertDialogContent>
<AlertDialogHeader>
<AlertDialogTitle>
Are you sure you want to force release?
</AlertDialogTitle>
<AlertDialogDescription>
<span>
This will force <Badge variant="secondary">{target.name}</Badge>{" "}
onto{" "}
<strong>
{deploymentName} {release.version}
</strong>
</span>
</AlertDialogDescription>
</AlertDialogHeader>
<AlertDialogFooter className="flex justify-end gap-2">
<AlertDialogCancel onClick={onClose}>Cancel</AlertDialogCancel>
<div className="flex-grow" />
<AlertDialogAction
className={buttonVariants({ variant: "destructive" })}
disabled={forceRelease.isPending}
onClick={() =>
forceRelease
.mutateAsync({
releaseId: release.id,
targetId: target.id,
environmentId: environmentId,
isForcedRelease: true,
})
.then(() => {
router.refresh();
setOpen(false);
onClose();
})
}
>
Force Release
</AlertDialogAction>
</AlertDialogFooter>
</AlertDialogContent>
</AlertDialog>
);
};

const validForceReleaseJobExecutionStatus = [
"scheduled",
"action_required",
"skipped",
"failed",
"cancelled",
"completed",
];

const TargetDropdownMenu: React.FC<{
release: { id: string; version: string };
environmentId: string | null;
target: { id: string; name: string; lockedAt: Date | null } | null;
deploymentName: string;
jobExecutionStatus: string;
}> = ({
release,
deploymentName,
target,
environmentId,
jobExecutionStatus,
}) => {
const [open, setOpen] = useState(false);
return (
<DropdownMenu open={open} onOpenChange={setOpen}>
<DropdownMenuTrigger asChild>
<Button variant="ghost" size="sm">
<TbDots size={16} />
</Button>
</DropdownMenuTrigger>
{target != null && (
<DropdownMenuContent align="end">
{target.lockedAt == null &&
environmentId != null &&
validForceReleaseJobExecutionStatus.includes(
jobExecutionStatus,
) && (
<ForceReleaseTargetDialog
release={release}
deploymentName={deploymentName}
target={target}
environmentId={environmentId}
onClose={() => setOpen(false)}
>
<DropdownMenuItem
onSelect={(e) => e.preventDefault()}
className="space-x-2"
>
<TbAlertTriangle size={16} />
<p>Force Release</p>
</DropdownMenuItem>
</ForceReleaseTargetDialog>
)}

{target.lockedAt == null &&
environmentId != null &&
!validForceReleaseJobExecutionStatus.includes(
jobExecutionStatus,
) && (
<TooltipProvider>
<Tooltip>
<TooltipTrigger asChild>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need aschild

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or did cursor say so

<div>
<DropdownMenuItem disabled className="space-x-2">
<TbAlertTriangle size={16} />
<p>Force Release</p>
</DropdownMenuItem>
</div>
</TooltipTrigger>
<TooltipContent>
Cannot force release while job execution is active
</TooltipContent>
</Tooltip>
</TooltipProvider>
)}
{target.lockedAt != null && environmentId != null && (
<TooltipProvider>
<Tooltip>
<TooltipTrigger asChild>
<div>
<DropdownMenuItem disabled className="space-x-2">
<TbAlertTriangle size={16} />
<p>Force Release</p>
</DropdownMenuItem>
</div>
</TooltipTrigger>
<TooltipContent>
Cannot force release while target is locked
</TooltipContent>
</Tooltip>
</TooltipProvider>
)}
</DropdownMenuContent>
)}
</DropdownMenu>
);
};

type TargetReleaseTableProps = {
releaseId: string;
release: { id: string; version: string };
deploymentName: string;
};

export const TargetReleaseTable: React.FC<TargetReleaseTableProps> = ({
releaseId,
release,
deploymentName,
}) => {
const jobConfigQuery = api.job.config.byReleaseId.useQuery(releaseId, {
const jobConfigQuery = api.job.config.byReleaseId.useQuery(release.id, {
refetchInterval: 5_000,
});

Expand All @@ -38,7 +230,7 @@ export const TargetReleaseTable: React.FC<TargetReleaseTableProps> = ({
.map(([envId, jobs]) => (
<Fragment key={envId}>
<TableRow className={cn("sticky bg-neutral-800/40")}>
<TableCell colSpan={3}>
<TableCell colSpan={4}>
{jobs[0]?.environment != null && (
<div className="flex items-center gap-4">
<div className="flex-grow">
Expand All @@ -56,11 +248,24 @@ export const TargetReleaseTable: React.FC<TargetReleaseTableProps> = ({
)}
>
<TableCell>{job.target?.name}</TableCell>
<TableCell className="flex items-center gap-1">
<JobTableStatusIcon status={job.jobExecution?.status} />
{capitalCase(job.jobExecution?.status ?? "scheduled")}
<TableCell>
<div className="flex items-center gap-1">
<JobTableStatusIcon status={job.jobExecution?.status} />
{capitalCase(job.jobExecution?.status ?? "scheduled")}
</div>
</TableCell>
<TableCell>{job.type}</TableCell>
<TableCell>
<TargetDropdownMenu
release={release}
deploymentName={deploymentName}
target={job.target}
environmentId={job.environmentId}
jobExecutionStatus={
job.jobExecution?.status ?? "scheduled"
}
/>
</TableCell>
</TableRow>
))}
</Fragment>
Expand Down
8 changes: 6 additions & 2 deletions ...paceSlug]/systems/[systemSlug]/deployments/[deploymentSlug]/releases/[versionId]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ export default async function ReleasePage({
};
}) {
const release = await api.release.byId(params.versionId);
const deployment = await api.deployment.bySlug(params);

if (release == null) notFound();
if (release == null || deployment == null) notFound();

const system = await api.system.bySlug(params);
const environments = await api.environment.bySystemId(system.id);
Expand Down Expand Up @@ -84,7 +85,10 @@ export default async function ReleasePage({
</Button>
</div>

<TargetReleaseTable releaseId={release.id} />
<TargetReleaseTable
release={release}
deploymentName={deployment.name}
/>
</ScrollArea>
</div>
);
Expand Down
Loading
Loading