Ces 984 customergroup product fixes

Component/CustomerGroups.php

@@ -60,9 +60,8 @@ public function execute($data = null)
             if ($taxClassId) {
                 foreach ($taxClass['groups'] as $group) {
                     try {
-                        if (isset($group['name'])) {
-                            $this->createCustomerGroup($group['name'], $taxClassId);
-                        }
+                        $this->validateGroupName($group);
+                        $this->createCustomerGroup($group['name'], $taxClassId);
                     } catch (ComponentException $e) {
                         $this->log->logError($e->getMessage());
                     }
@@ -100,6 +99,26 @@ private function createCustomerGroup($groupName, $taxClassId)
         );
     }
 
+    /**
+     * perform customer group name validation
+     *
+     * @param array $group
+     * @return null
+     * @throw ComponentException
+     */
+    private function validateGroupName(array $group)
+    {
+        if (!isset($group['name'])) {
+            throw new ComponentException(__('The customer group name is mandatory'));
+        }
+
+        if (strlen($group['name'])>32) {
+            throw new ComponentException(
+                __('The customer group name "%1" is too long (maximum length is 32 characters)', $group['name'])
+            );
+        }
+    }
+
     /**
      * Return tax class id when given name
      *

Component/Product/Image.php

@@ -5,8 +5,9 @@
 use Magento\Framework\Filesystem;
 use Magento\Framework\App\Filesystem\DirectoryList;
 use FireGento\FastSimpleImport\Model\Config;
-use Magento\Framework\HTTP\ZendClient;
-use Magento\Framework\HTTP\ZendClientFactory;
+use GuzzleHttp\Client;
+use GuzzleHttp\ClientFactory;
+use GuzzleHttp\Exception\GuzzleException;
 
 class Image
 {
@@ -15,11 +16,6 @@ class Image
      */
     protected $log;
 
-    /**
-     * @var ZendClientFactory
-     */
-    protected $httpClientFactory;
-
     /**
      * @var Filesystem
      */
@@ -36,21 +32,25 @@ class Image
     private $separator = ';';
 
     /**
-     * Image constructor.
+     * @var ClientFactory
+     */
+    private ClientFactory $clientFactory;
+
+    /**
      * @param Filesystem $filesystem
      * @param Config $importerConfig
-     * @param ZendClientFactory $httpClientFactory
+     * @param ClientFactory $clientFactory
      * @param LoggerInterface $log
      */
     public function __construct(
         Filesystem $filesystem,
         Config $importerConfig,
-        ZendClientFactory $httpClientFactory,
+        ClientFactory $clientFactory,
         LoggerInterface $log
     ) {
         $this->filesystem = $filesystem;
         $this->importerConfig = $importerConfig;
-        $this->httpClientFactory = $httpClientFactory;
+        $this->clientFactory = $clientFactory;
         $this->log = $log;
     }
 
@@ -90,19 +90,19 @@ public function isValueURL($url)
     public function downloadFile($value)
     {
         /**
-         * @var ZendClient $client
+         * @var Client $client
          */
-        $client = $this->httpClientFactory->create();
+        $client = $this->clientFactory->create(['config' => [
+            'base_uri' => $value
+        ]]);
         $response = '';
 
         try {
-            $response = $client
-                ->setUri($value)
-                ->request('GET')
-                ->getBody();
-        } catch (\Exception $e) {
+            $response = $client->request('GET')->getBody();
+        } catch (GuzzleException $e) {
             $this->log->logError($e->getMessage());
         }
+
         return $response;
     }
 
@@ -207,11 +207,12 @@ public function getImage($value)
      */
     public function getFileDirectory(\Magento\Framework\Filesystem\Directory\WriteInterface $file)
     {
-        $configurationValue = $this->importerConfig->getImportFileDir();
-        if (!empty($configurationValue)) {
-            return $file->getRelativePath($configurationValue);
+        try {
+            $configurationValue = $this->importerConfig->getImportFileDir();
+             return $file->getRelativePath($configurationValue);
+        } catch (\TypeError $e) {
+            return $file->getRelativePath('import');
         }
-        return $file->getRelativePath('import');
     }
 
     /**

Component/Product/Validator.php

@@ -125,7 +125,7 @@ public function getImportRowFailures(Importer $import, $importLines)
     {
         $failedRows = [];
         // Creates a validation model and runs the import data through so we can find which rows would fail
-        $validation = $import->createImportModel();
+        $validation = $import->getImportModel();
         $validationSource = $this->importAdapterFactory->create([
             'data' => $importLines,
             'multipleValueSeparator' => Products::SEPARATOR

Model/Processor.php

@@ -180,6 +180,7 @@ private function runAllComponents()
 
             // Loop through components and run them individually in the master.yaml order
             foreach ($master as $componentAlias => $componentConfig) {
+                if ($componentConfig['enabled'] === 0) continue;
                 // Run the component in question
                 $this->state->emulateAreaCode(
                     Area::AREA_ADMINHTML,

composer.json

@@ -20,7 +20,7 @@
     "phpunit/phpunit": "^6.2",
     "magento/magento-coding-standard": "5"
   },
-  "version": "3.2.0",
+  "version": "3.2.1",
   "autoload": {
     "files": [ "registration.php" ],
     "psr-4": {