-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
82 changed files
with
1,197 additions
and
385 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,35 @@ | ||
# Contributing | ||
|
||
Hola hola :). | ||
The following is a set of guidelines for contributing to pymm. | ||
Contributions are more than welcome using the fork and pull request approach 🙂 (if you are not familiar with this approach, please visit [_GitHub Docs PRs_](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests) for an extended documentation about collaborating with pull request; also, looking at previous merged pull requests helps to get familiar with this). | ||
|
||
## Ground Rules | ||
|
||
1. We use Black code formatting | ||
1. We use Pylint | ||
1. We document our code | ||
- We use Black code formatting | ||
- We use Pylint | ||
- We document our code | ||
|
||
## Pull Request Process | ||
## Contribute to the software | ||
|
||
1. Work on your own fork of the main repo | ||
1. Push your commits and make a pull request | ||
1. The changes are merged when your code has been approved | ||
1. In the main repo execute: | ||
1. **pip install -r dev-requirements.txt** (this installs the [_dev-requirements.txt_](https://github.com/cssr-tools/pymm/blob/main/dev-requirements.txt)) | ||
1. **black src/ tests/** (this formats the code) | ||
1. **pylint src/ tests/** (this analyses the code, and might rise issues that need to be fixed before the pull request) | ||
1. **mypy --ignore-missing-imports src/ tests/** (this is a static checker, and might rise issues that need to be fixed before the pull request) | ||
1. **pytest --cov=pymm --cov-report term-missing tests/** (this runs locally the tests, and might rise issues that need to be fixed before the pull request) | ||
1. **pushd docs & make html** (this generates the documentation, and might rise issues that need to be fixed before the pull request; if the build succeeds and if the contribution changes the documentation, then copy all content from the docs/_build/html/ folder and replace the files in the [_docs_](https://github.com/cssr-tools/pymm/tree/main/docs) folder) | ||
* Tip: See the [_CI.yml_](https://github.com/cssr-tools/pymm/blob/main/.github/workflows/CI.yml) script and the [_Actions_](https://github.com/cssr-tools/pymm/actions) for installation of _pymm_, as well as the execution of the six previous steps in Ubuntu 24.10 using Python 3.12. | ||
1. Squash your commits into a single commit (see this [_nice tutorial_](https://gist.github.com/lpranam/4ae996b0a4bc37448dc80356efbca7fa) if you are not familiar with this) | ||
1. Push your commit and make a pull request | ||
1. The maintainers will review the pull request, and if the contribution is accepted, then it will be merge to the main repo | ||
|
||
## Reporting issues or problems | ||
|
||
1. Issues or problems can be raised by creating a [_new issue_](https://github.com/cssr-tools/pymm/issues) in the repository GitHub page (if you are not familiar with this approach, please visit [_GitHub Docs Issues_](https://docs.github.com/en/issues/tracking-your-work-with-issues)). | ||
1. We will try to answer as soon as possible, but also any user is more than welcome to answer. | ||
|
||
## Seek support | ||
|
||
1. The preferred approach to seek support is to raise an Issue as described in the previous lines. | ||
1. We will try to answer as soon as possible, but also any user is more than welcome to answer. | ||
- An alternative approach is to send an email to any of the [_mantainers_](https://github.com/cssr-tools/pymm/blob/main/pyproject.toml). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
************ | ||
Contributing | ||
************ | ||
|
||
Contributions are more than welcome using the fork and pull request approach 🙂 (if you are not familiar with this approach, | ||
please visit `GitHub Docs PRs <https://docs.github.com/en/pull-requests/collaborating-with-pull-requests>`_ for an extended | ||
documentation about collaborating with pull request; also, looking at previous merged pull requests helps to get familiar with this). | ||
|
||
============ | ||
Ground Rules | ||
============ | ||
|
||
- We use Black code formatting | ||
- We use Pylint | ||
- We document our code | ||
|
||
========================== | ||
Contribute to the software | ||
========================== | ||
|
||
#. Work on your own fork of the main repo | ||
#. In the main repo execute: | ||
|
||
#. **pip install -r dev-requirements.txt** (this installs the `dev-requirements.txt <https://github.com/cssr-tools/pymm/blob/main/dev-requirements.txt>`_) | ||
#. **black src/ tests/** (this formats the code) | ||
#. **pylint src/ tests/** (this analyses the code, and might rise issues that need to be fixed before the pull request) | ||
#. **mypy --ignore-missing-imports src/ tests/** (this is a static checker, and might rise issues that need to be fixed before the pull request) | ||
#. **pytest --cov=pymm --cov-report term-missing tests/** (this runs locally the tests, and might rise issues that need to be fixed before the pull request) | ||
#. **pushd docs & make html** (this generates the documentation, and might rise issues that need to be fixed before the pull request; if the build succeeds and if the contribution changes the documentation, then copy all content from the docs/_build/html/ folder and replace the files in the `docs <https://github.com/cssr-tools/pymm/tree/main/docs>`_ folder) | ||
|
||
.. tip:: | ||
See the `CI.yml <https://github.com/cssr-tools/pymm/blob/main/.github/workflows/CI.yml>`_ script and the `Actions <https://github.com/cssr-tools/pymm/actions>`_ for installation of pymm, as well as the execution of the six previous steps in Ubuntu 24.10. | ||
|
||
#. Squash your commits into a single commit (see this `nice tutorial <https://gist.github.com/lpranam/4ae996b0a4bc37448dc80356efbca7fa>`_ if you are not familiar with this) | ||
#. Push your commit and make a pull request | ||
#. The maintainers will review the pull request, and if the contribution is accepted, then it will be merge to the main repo | ||
|
||
============================ | ||
Reporting issues or problems | ||
============================ | ||
|
||
#. Issues or problems can be raised by creating a `new issue <https://github.com/cssr-tools/pymm/issues>`_ in the repository GitHub page (if you are not familiar with this approach, please visit `GitHub Docs Issues <https://docs.github.com/en/issues/tracking-your-work-with-issues>`_). | ||
#. We will try to answer as soon as possible, but also any user is more than welcome to answer. | ||
|
||
============ | ||
Seek support | ||
============ | ||
|
||
#. The preferred approach to seek support is to raise an Issue as described in the previous lines. | ||
#. We will try to answer as soon as possible, but also any user is more than welcome to answer. | ||
|
||
- An alternative approach is to send an email to any of the `mantainers <https://github.com/cssr-tools/pymm/blob/main/pyproject.toml>`_. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
============ | ||
Installation | ||
============ | ||
|
||
The following steps work installing the dependencies in Linux via apt-get using Python3.12. | ||
While using package managers such as Anaconda, Miniforge, or Mamba might work, these are not tested. | ||
|
||
Python package | ||
-------------- | ||
|
||
To install the **pymm** executable from the development version: | ||
|
||
.. code-block:: bash | ||
pip install git+https://github.com/cssr-tools/pymm.git | ||
If you are interested in a specific version (e.g., v2024.10) or in modifying the source code, then you can clone the repository and | ||
install the Python requirements in a virtual environment with the following commands: | ||
|
||
.. code-block:: console | ||
# Clone the repo | ||
git clone https://github.com/cssr-tools/pymm.git | ||
# Get inside the folder | ||
cd pymm | ||
# For a specific version (e.g., v2024.10), or skip this step (i.e., edge version) | ||
git checkout v2024.10 | ||
# Create virtual environment (to specific Python, python3.12 -m venv vpymm) | ||
python3 -m venv vpymm | ||
# Activate virtual environment | ||
source vpymm/bin/activate | ||
# Upgrade pip, setuptools, and wheel | ||
pip install --upgrade pip setuptools wheel | ||
# Install the pymm package | ||
pip install -e . | ||
# For contributions/testing/linting, install the dev-requirements | ||
pip install -r dev-requirements.txt | ||
.. tip:: | ||
|
||
Typing **git tag -l** writes all available specific versions. | ||
|
||
OpenFOAM | ||
-------- | ||
|
||
See the `OpenFOAM page <https://openfoam.org/download/12-ubuntu/>`_, where from OpenFOAM-12 the simulator is available via apt get. | ||
|
||
Gmsh | ||
---- | ||
|
||
See the `Gmsh page <https://gmsh.info/#Download>`_. | ||
|
||
|
||
.. tip:: | ||
|
||
See the `CI.yml <https://github.com/cssr-tools/pymm/blob/main/.github/workflows/CI.yml>`_ script | ||
for installation of pymm in Ubuntu using Python3.12. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.