Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve lint #312

Closed
wants to merge 1 commit into from
Closed

Improve lint #312

wants to merge 1 commit into from

Conversation

vecmezoni
Copy link
Contributor

This PR is still in progress, just wanted to review this proof of concept.

Partially fixes #84 #135 #245

@tonyganch
Copy link
Member

There are two more issues you can find helpful: #261 and csscomb/core#4

  1. New methods should not be static, so the changes should be done in csscomb/core repo.
  2. Some changes should be done in Plugins API: plugins should have a separate lint method and lintMessage field for user-friendly error messages.
  3. You can find an example of what lint... methods should return in this comment.
  4. Method that formats error messages (displays a few lines before/after and points where error is) should live in this repo.

I can help you with all of these if you want.

@tonyganch tonyganch closed this Sep 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More info in lint mode
2 participants