Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: check for signed commits #16

Merged
merged 2 commits into from
Feb 7, 2024
Merged

ci: check for signed commits #16

merged 2 commits into from
Feb 7, 2024

Conversation

marijanp
Copy link
Contributor

@marijanp marijanp commented Feb 2, 2024

No description provided.

@koxu1996
Copy link
Contributor

koxu1996 commented Feb 2, 2024

Suggestion: We can run commit checks independently, so developers could see if build-test works, even if they forget to sign the commits.

@marijanp What about adding separate workflow, e.g. .github/workflows/pre-check.yml:

name: Check signed commits in PR 
on: pull_request_target

jobs:
  check-signed-commits:
    name: Check signed commits in PR
    runs-on: ubuntu-latest
    permissions:
      contents: read
      pull-requests: write
    steps:
      - name: Check signed commits in PR
        uses: 1Password/check-signed-commits-action@v1

@marijanp marijanp self-assigned this Feb 6, 2024
@marijanp marijanp force-pushed the check-signed-commits branch 2 times, most recently from 50cd54b to 7865b4a Compare February 6, 2024 08:45
@marijanp marijanp force-pushed the check-signed-commits branch from 60c09d4 to 26db3a1 Compare February 6, 2024 08:49
@marijanp marijanp requested a review from koxu1996 February 6, 2024 08:50
@marijanp marijanp merged commit 94b6346 into main Feb 7, 2024
5 of 6 checks passed
@marijanp marijanp deleted the check-signed-commits branch February 7, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants