Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dehardcode chain name in CLI #156

Merged
merged 7 commits into from
Jul 25, 2024

Conversation

koxu1996
Copy link
Contributor

This PR fixes #155.

  1. Added simple endpoint to Kairos server, that returns chain name:
$ curl 127.0.0.1:9999/api/v1/chain_name
"casper-net-1"
  1. Introduced optional --chain_name argument for CLI's deposit:
$ kairos-cli deposit --help | grep chain
      --chain-name <NAME>              Name of the chain, to avoid the deploy from being accidentally included in a different chain

NOTE: Help text is based on casper-client.

In case chain name is not provided, CLI will query server for it.

@koxu1996 koxu1996 self-assigned this Jul 23, 2024
@marijanp marijanp merged commit a06b32b into main Jul 25, 2024
4 checks passed
@marijanp marijanp deleted the feature/remove-compiled-chain-name-from-client branch July 25, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client uses hardcoded chain name
3 participants