Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persists user's own rstudio-prefs.json #157

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

dmalan
Copy link
Member

@dmalan dmalan commented Sep 12, 2024

@rongxin-liu, what do you think is best here? I'm currently persisting user prefs to (1), but would (2) or (3) perhaps be best?

  1. /workspaces/$RepositoryName/rstudio-prefs.json, in which case it appears in file explorer
  2. /workspaces/$RepositoryName/.config/rstudio/rstudio-prefs.json, similar to where it ends up in rstudio container, but won't be backed up (at the moment) via GitDoc, since it'd be in a dotfolder
  3. /home/ubuntu/.config/rstudio/rstudio-prefs.json, more similar to where it ends up in rstudio container, but it wouldn't persist after rebuilds either
  4. other...

@dmalan dmalan added the enhancement New feature or request label Sep 12, 2024
@rongxin-liu
Copy link
Contributor

When people take the CS50R course, they rarely need to update (rebuild) their Codespace (because running rstudio ensures they get the latest RStduio so they don't really need the latest Codespace version), so options 2 and 3 are fine. It wouldn't be much hassle for people to re-customize their R studio after a codespace rebuild.

@CarterZenke
Copy link
Member

Agreed with @rongxin-liu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants