Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eosfs: use external script for home creation + drop support for shadow namespace #4984

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

glpatcern
Copy link
Member

@glpatcern glpatcern commented Dec 3, 2024

This comes as part of the effort to operate EOS without being root, see #4977

In this PR the post-home creation hook (and corresponding flag) is replaced by a create_home_hook, and the following configuration parameters are suppressed:

  • shadow_namespace
  • share_folder
  • default_quota_bytes
  • default_secondary_quota_bytes
  • default_quota_files
  • uploads_namespace (unused)

Copy link

update-docs bot commented Dec 3, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@diocas diocas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason for the shadow ns? Maybe it's worth to explain in the PR why it's ok to remove it.

pkg/storage/utils/eosfs/eosfs.go Outdated Show resolved Hide resolved
@glpatcern
Copy link
Member Author

What was the reason for the shadow ns? Maybe it's worth to explain in the PR why it's ok to remove it.

I actually put that in a ADR. Hugo just confirmed this is a legacy attempt to implement the "share jail", but it has never been used.

@glpatcern glpatcern merged commit 3c6222b into cs3org:fix/stat-as-daemon Dec 3, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants