Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support filepaths starting with multiple '../' #18

Open
wants to merge 1 commit into
base: zarfsec-multiple-dot-dot-slashes
Choose a base branch
from

Conversation

Zarfsec
Copy link

@Zarfsec Zarfsec commented Jul 26, 2023

Quite 'dirty' way to fix imports starting with multiple '../'.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we count the number of times ../ appears, and use that number times 3 where we have path[3:] etc? Would be cleaner and more robust, i.e., in case a path starts with ../../../../../.

@webthethird webthethird changed the base branch from main to zarfsec-multiple-dot-dot-slashes July 26, 2023 18:45
@webthethird
Copy link
Collaborator

I believe the Pytest tests are failing because your fork does not have the Etherscan API keys and RPC urls in its repo secrets. If you can add your own keys/urls in your fork, then when the tests are re-run they should pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants