Preserve Last Modification Date #528

JustFanta01 · 2024-04-10T13:48:37Z

Hello guys 👋
This is our attempt to preserve the last modified date for various clouds [/issues/239]

Me, @WheelyMcBones and @taglioIsCoding have made changes for:

OneDrive: we used an async PATCH to modify the FileSystemInfo.lastModifiedDateTime property of the file we are uploading;
Google Drive: we modified the file metadata using the setModifiedTime(...) API;
DropBox: we used the withClientModified(...) API to modify the date;
WebDAV/NextCloud: Webdav doesn't provide a standard way for doing it. But OwnCloud/NextCloud use a custom header, the “X-OC-Mtime”, so we have added it to the upload request, passing the modified date;
pCloud: In the API call we provide the modified date as a parameter but we weren’t able to test it because the pCloud system does not allow us to register a new app.

At the moment we haven't implemented for:

LocalStorage: We haven't found a easy and feasible way to implement it for the LocalStorage. We've encountered some troubles with .setLastModifiedDate() and the contentResolver(...).query(..., DocumentsContract.Document.COLUMN_LAST_MODIFIED).
S3: As far as we know S3 doesn't allow to change the Last-Modified date metadata.

Finally we have run all the tests successfully!

Summary by CodeRabbit

New Features
- Enhanced OneDrive integration to retrieve and update the last modified date of files.
- Improved WebDav file handling to include setting a custom modified date during file uploads.

The UriBasedDataSource via the ContentResolverUtil can obtain the original last modification date of the source. This info can pass through all architecture to the data layer and used by the various APIs.

…od-date-dropbox

No need of modified list because the last modified date was already fetched (not tested)

Onedrive provide a "fileSystemInfo resource type" [1] that contains properties that are reported by the device's local file system for the local version of an item. To fetch the original last modified date we have to pass an additional argument which will be stored server side and retrieved in a second moment. In the uploadFile() method a new PATCH request have been added to update those info. In the chunkedUploadFile() is sufficient add a property to the request. When a CloudNode is created by the OnedriveCloudNodeFactory the fileSystemInfo are used. [1] https://learn.microsoft.com/en-us/graph/api/resources/filesysteminfo?view=graph-rest-1.0#notes

…ustFanta01/cryptomator-android into feature/preserve-mod-date-main

CLAassistant · 2024-04-10T13:48:44Z

All committers have signed the CLA.

coderabbitai · 2024-04-10T13:48:58Z

Walkthrough

This update enhances file metadata handling across various cloud storage integrations in Cryptomator. It introduces mechanisms to preserve and accurately reflect the last modified dates of files, ensuring consistency and reliability in metadata management across different platforms and local encryption scenarios.

Changes

File Path	Change Summary
`.data/src/apiKey/java/org/cryptomator/data/cloud/*`	Modified handling of last modified dates for various cloud storage providers like OneDrive and pCloud.
`.data/src/main/java/org/cryptomator/data/cloud/webdav/network/WebDavClient.kt`	Updated `writeFile` method to accept `modifiedDate` parameter.

Possibly related issues

Last modified timestamp not preserved when using pCloud cryptomator#2058: Changes in handling last modified dates for pCloud and OneDrive could address the timestamp preservation concerns outlined in this issue.
Keep modification date of original file #239: Updates related to file timestamp preservation during uploads and exports align with the objectives of maintaining original timestamps in the Cryptomator app.

🐰✨
Little bits and bytes, all in a row,
Timestamps and dates, now correct they show.
Across the clouds, through cryptic haze,
Files keep their times, in all their days.
Cheers to the devs, with minds so bright,
For keeping our data just right! 🌟📅
🐰💾

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between cd22b4b and 4dbcdb8.

Files selected for processing (1)

data/src/apiKey/java/org/cryptomator/data/cloud/onedrive/OnedriveCloudNodeFactory.kt (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 5

data/src/main/java/org/cryptomator/data/cloud/crypto/CryptoImplDecorator.kt

data/src/apiKey/java/org/cryptomator/data/cloud/onedrive/OnedriveImpl.kt

data/src/main/java/org/cryptomator/data/cloud/webdav/network/ConnectionHandlerHandlerImpl.kt

data/src/apiKey/java/org/cryptomator/data/cloud/onedrive/OnedriveCloudNodeFactory.kt

SailReal

Thank you for your input 💚, we are almost there!

Please have a look at my suggestions, also here are some more general notes
- In Kotlin, you do not need a semicolon at the end of a statement
- Use automatic formatting, some if statements are not formatted correctly, for example
- We still need to improve our gitignore, I know, but please don't commit the changes in the .idea files
- What about other WebDAV servers, have you found any headers we can set in addition to Nextcloud's?

I will test your changes and get back to you.

data/src/apiKey/java/org/cryptomator/data/cloud/onedrive/OnedriveImpl.kt

data/src/main/java/org/cryptomator/data/cloud/webdav/network/WebDavClient.kt

domain/src/main/java/org/cryptomator/domain/usecases/cloud/DataSource.kt

domain/src/main/java/org/cryptomator/domain/usecases/cloud/FileBasedDataSource.kt

presentation/src/main/java/org/cryptomator/presentation/util/ContentResolverUtil.kt

coderabbitai

Actionable comments posted: 1

data/src/apiKey/java/org/cryptomator/data/cloud/onedrive/OnedriveImpl.kt

SailReal

We are on the right track 👍

data/src/apiKey/java/org/cryptomator/data/cloud/onedrive/OnedriveCloudNodeFactory.kt

SailReal · 2024-04-19T10:38:54Z

Have you found any other headers related to other WebDAV implementations that we can set to adjust the modification date on other servers as well?

taglioIsCoding · 2024-04-19T12:50:51Z

Nope, we tried looking for other WebDav implementations but the documentations are pretty poor in terms of modification date headers, so we preferred to keep our focus on thumbnails implementation.

coderabbitai

Actionable comments posted: 1

data/src/apiKey/java/org/cryptomator/data/cloud/onedrive/OnedriveCloudNodeFactory.kt

SailReal

LGTM 👍

Thank you very much for your contribution!

taglioIsCoding and others added 16 commits April 2, 2024 12:14

Preserve last modified on Dropbox

e4986d8

Added modifiedDate in DataSource

141a000

The UriBasedDataSource via the ContentResolverUtil can obtain the original last modification date of the source. This info can pass through all architecture to the data layer and used by the various APIs.

Merge branch 'feature/preserve-mod-date-main' into feature/preserve-m…

b00ab2e

…od-date-dropbox

Add modified date into gdrive metadata

f0a7e5f

No need of modified list because the last modified date was already fetched (not tested)

last modified date for WebDAV and NextCloud

ccdb472

Edited .gitignore

bfeb686

modified date with Optional for GDrive, DropBox, WebDav (not tested)

a1edf87

preserve last modified date on pCloud (not tested!)

633fbe4

Modified date with Optional in pCloud

2bf641c

last modified date for OneDrive

c045f7c

modified chunkedUploadFile with modified date

1d71160

modified date with Optional for OneDrive

32c5ef7

Merge branch 'cryptomator:develop' into feature/preserve-mod-date-main

2098640

Added modifiedDate() in UploadFileTest

7e281a2

Merge branch 'feature/preserve-mod-date-main' of https://github.com/J…

d1a8d7c

…ustFanta01/cryptomator-android into feature/preserve-mod-date-main

coderabbitai bot reviewed Apr 10, 2024

View reviewed changes

SailReal requested changes Apr 10, 2024

View reviewed changes

PR requested changes (not tested)

ab9f890

SailReal added the pr:safe PR is considered safe for testing label Apr 10, 2024

coderabbitai bot reviewed Apr 10, 2024

View reviewed changes

data/src/apiKey/java/org/cryptomator/data/cloud/onedrive/OnedriveImpl.kt Show resolved Hide resolved

JustFanta01 added 2 commits April 18, 2024 12:43

Revert changes to the .idea/_ files and the .gitignore

38b4633

Removed patchAsync request when not useful for Onedrive

cd22b4b

JustFanta01 requested a review from SailReal April 18, 2024 16:13

SailReal requested changes Apr 18, 2024

View reviewed changes

data/src/apiKey/java/org/cryptomator/data/cloud/onedrive/OnedriveCloudNodeFactory.kt Outdated Show resolved Hide resolved

Fixed nullable last modified date for OneDrive

4dbcdb8

coderabbitai bot reviewed Apr 19, 2024

View reviewed changes

data/src/apiKey/java/org/cryptomator/data/cloud/onedrive/OnedriveCloudNodeFactory.kt Show resolved Hide resolved

SailReal approved these changes Apr 22, 2024

View reviewed changes

SailReal merged commit 1ef6bfe into cryptomator:develop Apr 22, 2024
1 check passed

SailReal mentioned this pull request Apr 22, 2024

Keep modification date of original file #239

Closed

SailReal added this to the 1.10.1 milestone Apr 22, 2024

SailReal mentioned this pull request Apr 22, 2024

Preserve Last modified date on upload #285

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Preserve Last Modification Date #528

Preserve Last Modification Date #528

JustFanta01 commented Apr 10, 2024 •

edited by coderabbitai bot

Loading

CLAassistant commented Apr 10, 2024 •

edited

Loading

coderabbitai bot commented Apr 10, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

SailReal left a comment

coderabbitai bot left a comment

SailReal left a comment

SailReal commented Apr 19, 2024

taglioIsCoding commented Apr 19, 2024

coderabbitai bot left a comment

SailReal left a comment

Preserve Last Modification Date #528

Preserve Last Modification Date #528

Conversation

JustFanta01 commented Apr 10, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

CLAassistant commented Apr 10, 2024 • edited Loading

coderabbitai bot commented Apr 10, 2024 • edited Loading

Walkthrough

Changes

Possibly related issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

SailReal left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

SailReal left a comment

Choose a reason for hiding this comment

SailReal commented Apr 19, 2024

taglioIsCoding commented Apr 19, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

SailReal left a comment

Choose a reason for hiding this comment

JustFanta01 commented Apr 10, 2024 •

edited by coderabbitai bot

Loading

CLAassistant commented Apr 10, 2024 •

edited

Loading

coderabbitai bot commented Apr 10, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)