-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Jade signing issues with Swan Vault #2421
Merged
moneymanolis
merged 10 commits into
cryptoadvance:master
from
moneymanolis:mm/jade-signing-issue-with-swan-vault
Mar 27, 2024
Merged
Fix Jade signing issues with Swan Vault #2421
moneymanolis
merged 10 commits into
cryptoadvance:master
from
moneymanolis:mm/jade-signing-issue-with-swan-vault
Mar 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test hwi code (version
… to skip_hwi_initialisation + some simplifications
…hanges to be on the safe side (avoid name collusion with built-in fetch + random id)
moneymanolis
added
bug
Something isn't working
enhancement
New feature or request
labels
Mar 13, 2024
✅ Deploy Preview for specter-desktop-docs canceled.
|
@JamieDriver could you check those Jade related commits: |
JamieDriver
reviewed
Mar 14, 2024
JamieDriver
reviewed
Mar 14, 2024
JamieDriver
reviewed
Mar 14, 2024
JamieDriver
reviewed
Mar 14, 2024
JamieDriver
reviewed
Mar 14, 2024
… return up in jade client
All good with me. |
stepansnigirev
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2402
This PR also includes:
enforcehwiinitialisation
toskiphwiinitialisation
Tested