Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New documentations #1885 #2409

Merged
merged 24 commits into from
Feb 27, 2024
Merged

New documentations #1885 #2409

merged 24 commits into from
Feb 27, 2024

Conversation

j0sh21
Copy link
Contributor

@j0sh21 j0sh21 commented Jan 12, 2024

Device Creation Guide for Specter Hardware
Wallet Creation Guide for Specter

Relates to Issue #1885 . I got knowledge about this issue via NodeSignal Podcast.

j0sh21 and others added 8 commits December 26, 2023 18:30
… info

- Moved 'OS-Specific Apps for Specter Desktop' section to immediately follow 'Installation Methods' for better logical flow and prominence.
- Added information about Electrum connection availability since version 2.0.0 in the 'Future Developments of Specter Desktop' section for up-to-date and accurate documentation.
-Changed Title to "Installation Method Decision Guide" instead of "Installation Guide"
Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for specter-desktop-docs ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/specter-desktop-docs/deploys/65ddce8d823ea407898bdff9
😎 Deploy Preview https://deploy-preview-2409--specter-desktop-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@j0sh21 j0sh21 changed the title New dokumentations New documentations #1885 Jan 12, 2024
docs/DeviceCreationGuide.md Outdated Show resolved Hide resolved
docs/WalletCreationGuide.md Outdated Show resolved Hide resolved
docs/WalletCreationGuide.md Outdated Show resolved Hide resolved
docs/WalletCreationGuide.md Outdated Show resolved Hide resolved
docs/WalletCreationGuide.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@k9ert k9ert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments. And please also adjust the mkdocs.yml to include the new guides into the menu.

j0sh21 and others added 5 commits January 13, 2024 18:38
commit suggestion from k9ert

Co-authored-by: k9ert <[email protected]>
Linked new WalletCreationGuide and DeviceCreationGuide in the Menue
Added Link to install guide
Added Link to Node connection guide
Creating wallet: Reference to import device first
Backup wallet: Improved explenation about steel backup
@j0sh21
Copy link
Contributor Author

j0sh21 commented Jan 13, 2024

All done! 🚀

Added real world examples for wallets and derivation paths.
Linked readme with pictured Step by Step guide.
Added Some basic Common Issues, maybe link faq?
Added examples for Single/Multisig wallets
small fix in hierarchy
@k9ert k9ert added the documentation Improvements or additions to documentation label Jan 16, 2024
Copy link
Collaborator

@k9ert k9ert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did another round of review. See my comments. See my comments. I think we're pretty much done with the installation guide but wallets/device guide needs still some work.

mkdocs.yml Outdated Show resolved Hide resolved
docs/DeviceCreationGuide.md Outdated Show resolved Hide resolved
docs/DeviceCreationGuide.md Outdated Show resolved Hide resolved
docs/DeviceCreationGuide.md Outdated Show resolved Hide resolved
docs/DeviceCreationGuide.md Outdated Show resolved Hide resolved
docs/DeviceCreationGuide.md Outdated Show resolved Hide resolved
docs/DeviceCreationGuide.md Outdated Show resolved Hide resolved
docs/WalletCreationGuide.md Show resolved Hide resolved
docs/WalletCreationGuide.md Outdated Show resolved Hide resolved
docs/WalletCreationGuide.md Show resolved Hide resolved
swapped device and wallet creation guide.
Fixed various comments
docs/WalletCreationGuide.md Outdated Show resolved Hide resolved
docs/DeviceCreationGuide.md Outdated Show resolved Hide resolved
docs/DeviceCreationGuide.md Outdated Show resolved Hide resolved
docs/DeviceCreationGuide.md Outdated Show resolved Hide resolved
fix double space and no new line.
- Pointed out that hardware wallets with shitcoin support are less secure.
- adjusted link integration
- removed picture reference in the wallets overview
@k9ert k9ert merged commit a052373 into cryptoadvance:master Feb 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants