Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #2305 #2338

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix for #2305 #2338

wants to merge 7 commits into from

Conversation

SeanHampson
Copy link
Contributor

Don't display button(Run the numbers) until sync is complete

Prevent fetchTotalSupply() from running unless sync is complete

Don't display button(Run the numbers) until sync is complete

Prevent fetchTotalSupply() from running unless sync is complete
@netlify
Copy link

netlify bot commented May 23, 2023

Deploy Preview for specter-desktop-docs canceled.

Name Link
🔨 Latest commit eef3c40
🔍 Latest deploy log https://app.netlify.com/sites/specter-desktop-docs/deploys/650adf4f998da00008006e26

@SeanHampson
Copy link
Contributor Author

First public contribution - leave advice please

@k9ert
Copy link
Collaborator

k9ert commented Jul 27, 2023

Thanks! Tested, works! Sorry this took so long! For some reason the cypress tests are failing. We need to fix them for before the merge.

@@ -39,6 +39,7 @@
{% endif %}
<div class="px-3 pb-4">
<p class="text-center text-sm m-4" id="total_supply"></p>
{% if verificationprogress >= 100 %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  File "/Users/kim/src/specter-desktop/src/cryptoadvance/specter/templates/includes/sidebar/components/node_connection.jinja", line 12, in top-level template code
    <div class="hidden" id="node-info-popup">{% include node.node_info_template() %}</div>
    ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/kim/src/specter-desktop/src/cryptoadvance/specter/templates/node/components/bitcoin_core_info.jinja", line 42, in top-level template code
    {% if verificationprogress >= 100 %}
    ^^^^^^^^^^^^^^^^^^^^^^^^^
jinja2.exceptions.UndefinedError: 'verificationprogress' is undefined

That's what the tests are complaining about. Why do you think it's defined?

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for specter-desktop-docs canceled.

Name Link
🔨 Latest commit fa6028f
🔍 Latest deploy log https://app.netlify.com/sites/specter-desktop-docs/deploys/666821b0c17d98000890d958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants