Fix insertion bug in node_query_ #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crvs
approved these changes
Jul 9, 2024
KDTree.cpp
Outdated
| @@ -135,6 +135,7 @@ void KDTree::node_query_( | |||
| std::upper_bound(k_nearest_buffer.begin(), k_nearest_buffer.end(), | |||
| node_distance, detail::compare_node_distance); | |||
| if (insert_it == k_nearest_buffer.end() || | |||
| std::next(insert_it) == k_nearest_buffer.end() || | |||
| insert_it->first != std::next(insert_it)->first) { | |||
There was a problem hiding this comment.
this condition was wrong to begin with, it just doesn't make a difference in GCC for the reason you pointed out in the bug report, instead the insertion should happen when:
insert_itis NOT theend(), or,insert_itis theend()pointer, but we still have not filled the buffer withnum_nearestelements.
So the final insertion condition should be:
(insert_it != k_nearest_buffer.end() || k_nearest_buffer.size() < num_nearest)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12
Fixed a bug in
KDTree::node_query_thatk_nearest_buffer.insert()might not be executed in certain environments when the next ofinsert_itisk_nearest_buffer.end().