Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search bar component #208

Merged
merged 7 commits into from
Jul 25, 2024
Merged

Add search bar component #208

merged 7 commits into from
Jul 25, 2024

Conversation

kishan1735
Copy link
Contributor

  1. I haven't created the search results page, its just the search bar
  2. The search results are being stored in local storage, can be used by the search results page

@skoriop skoriop linked an issue Jul 25, 2024 that may be closed by this pull request
Add search bar that calls search service #201
Closed
@skoriop skoriop self-requested a review July 25, 2024 10:43
skoriop
skoriop requested changes Jul 25, 2024
View reviewed changes
Copy link
Member

@skoriop skoriop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a few small things to clean up:

frontend/src/components/navbar.tsx Outdated Show resolved Hide resolved
frontend/src/SearchResults.tsx Outdated Show resolved Hide resolved
frontend/src/SearchResults.tsx Outdated Show resolved Hide resolved
@skoriop skoriop self-requested a review July 25, 2024 12:07
skoriop
skoriop approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@skoriop skoriop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skoriop skoriop added the ready Ready to be merged (used by our GitHub Actions pipeline) label Jul 25, 2024
@skoriop skoriop added this pull request to the merge queue Jul 25, 2024
Merged via the queue into master with commit 4a7bb71 Jul 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skoriop skoriop skoriop approved these changes

Assignees
No one assigned
Labels
ready Ready to be merged (used by our GitHub Actions pipeline)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add search bar that calls search service
2 participants
@kishan1735 @skoriop