fix(cmd/provider/main.go): External Secrets Store initialization #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
take-five
force-pushed
the
fix-ess-alpha-feature
branch
from
4ee25fc to
38d5b4f
Compare
Currently, even when command-line flag `--enable-external-secret-stores` is passed to the generated provider, the feature is not enabled. Apparently, `o.Features.Enable(features.EnableAlphaExternalSecretStores)` was missing from the generated code. I also copied how `o.ESSOptions` are initialized from [one of AWS providers][1], otherwise the program would crash. [1]: https://github.com/crossplane-contrib/provider-upjet-aws/blob/main/cmd/provider/acm/zz_main.go Signed-off-by: Alexey Mikhaylov <[email protected]>
take-five
force-pushed
the
fix-ess-alpha-feature
branch
from
38d5b4f to
8d880a1
Compare
jeanduplessis
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Currently, even when command-line flag
--enable-external-secret-storesis passed to the generated provider, the feature is not enabled.Apparently,
o.Features.Enable(features.EnableAlphaExternalSecretStores)was missing from the generated code.I also copied how
o.ESSOptionsare initialized from one of AWS providers, otherwise the program would crash.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I updated
cmd/provider/main.gofile in the provider I'm currently working on, and tested that I can publish connection secrets withspec.publishConnectionDetailsToattribute.