Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v1): switch meta.pkg to v1 and fix one issue in storeconfig #57

Merged
merged 1 commit into from
Sep 17, 2023
Merged

feat(v1): switch meta.pkg to v1 and fix one issue in storeconfig #57

merged 1 commit into from
Sep 17, 2023

Conversation

haarchri
Copy link
Contributor

Description of your changes

set v1 for meta.pkg.crossplane.io
crossplane want's to remove v1alpha1 versions from meta.pkg.crossplane.io

  • set storeconfig annotations to template to set to correct ${PROVIDER_NAME_LOWER}

crossplane/crossplane#4634

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@jeanduplessis jeanduplessis merged commit f49ec6d into crossplane:main Sep 17, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanduplessis jeanduplessis jeanduplessis approved these changes

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haarchri @jeanduplessis