-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stdio options to spawn #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added |
Example from above: spawn(["<COMMAND>"], {}, undefined, {
stdin: "inherit",
stdout: "inherit",
stderr: "inherit",
}); |
Interesting, great work! Will review this asap. |
That should be fixed now |
Run |
Passing locally now |
Released through |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option to pass a
stdio
argument tospawn()
. This allows you to interact more with the child process. For example, in Deno, you can pass the host process's stdio with:This is fully backwards-compatible - if this argument is omitted it should run identically to the current version of
@cross/utils
.I also removed the Deno and Bun implementations as both have decent Node compatibility covering
spawn()
, with just one quite small polyfill required in Bun.Separately, I've also added an
@cross/utils/stdio
module to get the current process's stdio streams more easily across platforms (again, the Node API is mostly compatible with all 3 runtimes, though a small polyfill is again required for Bun) . With this, the above can be rewritten like this: