Fix Issue #2 #4
Merged
Fix Issue #2 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfiguration to allow defining webhook tokens at project level feat(README.md): update README with information about the webhook_token field in project configuration feat(conf.go): add WebHookToken field to ApprovRule struct to support defining webhook tokens at project level feat(conf.go): add WebHookToken field to Config struct to support defining a global webhook token feat(conf_test.go): update test data to include webhook_token field in project configuration feat(webservices.go): add logic to handle and validate X-Gitlab-Token header in PostApproval endpoint feat(webservices.go): add support for using project-specific webhook token in PostApproval endpoint logic feat(webservices.go): add support for using global webhook token if project-specific token is not defined in PostApproval endpoint logic
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(README.md): add support for project-specific webhook_token in configuration to allow defining webhook tokens at project level
feat(README.md): update README with information about the webhook_token field in project configuration
feat(conf.go): add WebHookToken field to ApprovRule struct to support defining webhook tokens at project level
feat(conf.go): add WebHookToken field to Config struct to support defining a global webhook token
feat(conf_test.go): update test data to include webhook_token field in project configuration
feat(webservices.go): add logic to handle and validate X-Gitlab-Token header in PostApproval endpoint
feat(webservices.go): add support for using project-specific webhook token in PostApproval endpoint logic
feat(webservices.go): add support for using global webhook token if project-specific token is not defined in PostApproval endpoint logic