Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring name #40

Closed
wants to merge 3 commits into from
Closed

Allow configuring name #40

wants to merge 3 commits into from

Conversation

dudo
Copy link
Collaborator

@dudo dudo commented May 7, 2024

Addresses #39. This should keep existing behavior if the new annotations aren't added.

I haven't modified, or ran any tests... and it looks like we don't have CI. I'll see what I can do to get my env set up (I prefer keeping everything dockerized, though)

Checklist

  • Add functionality
  • Verify tests
  • Update readme

@aflanagan
Copy link
Contributor

aflanagan commented May 7, 2024

@dudo Dang you're fast! I just opened the repo to start working on this :)

I'll take a look through your PR, and am happy to help as you'd like. I also haven't looked into running the test suite locally, but it should run here via GH actions. I'm not sure why that didn't kick off when you opened that initial PR. I'll take a look at that now.

EDIT: I believe those will run on the next commit here.

@dudo
Copy link
Collaborator Author

dudo commented May 10, 2024

Hey @aflanagan! I don't think those test failures are related to my changes. I'll punt to you.

@aflanagan
Copy link
Contributor

@dudo I just added you as a maintainer, could you try opening this PR again with a branch based off of this repo instead of your fork? The failures are due to the following GH Actions policy (which makes sense)

Anyone with collaborator access to this repository can use these secrets and variables for actions. They are not passed to workflows that are triggered by a pull request from a fork.

@dudo
Copy link
Collaborator Author

dudo commented May 13, 2024

superseded with #41

@dudo dudo closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants