Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows, update API version, update testing suite #16

Open
wants to merge 76 commits into
base: master
Choose a base branch
from
Open

Add Windows, update API version, update testing suite #16

wants to merge 76 commits into from

Conversation

jdotjdot
Copy link
Contributor

@jdotjdot jdotjdot commented May 20, 2022 •
edited
Loading

  • Adds full Windows functionality to cronitor discover.
  • Upgrades CLI to use the latest API version
  • Updates all tests to work, moves tests to bats framework, adds additional tests for Windows

@jdotjdot jdotjdot requested review from aflanagan and shaneharter and removed request for aflanagan May 20, 2022 04:28
@jdotjdot jdotjdot marked this pull request as ready for review May 20, 2022 04:28
jdotjdot added 26 commits June 23, 2022 14:46
@jdotjdot
last linux test
7996509
@jdotjdot
Pin API version
3173fc3
@jdotjdot
unremove tests stopped for key
cd6e202
@jdotjdot
fix fixtures reference
d021fca
@jdotjdot
test output
926e21d
@jdotjdot
reorder crontab
eb53663
@jdotjdot
split exec test windows/linux
73631cf
@jdotjdot
add bats minimum version
693f572
@jdotjdot
try without using BATS_TMPDIR on windows for logfile
1e203ab
@jdotjdot
try to specify CLI_CRONTAB_TEMP
2c4e012
@jdotjdot
Revert "try without using BATS_TMPDIR on windows for logfile"
fd2af7d 
This reverts commit 1e203ab.
@jdotjdot
what is wrong here
d456804
@jdotjdot
whoops
5b5f954
@jdotjdot
more tests
78e69c0
@jdotjdot
whats going on
5d0be16
@jdotjdot
try with windows syntax
35ee6a3
@jdotjdot
exit codes
7854f05
@jdotjdot
lets try again
958d89e
@jdotjdot
silence that annoying failing test
fe839a5
@jdotjdot
test powershell directly
283b599
@jdotjdot
fix test_helper load
a0b3f2a
@jdotjdot
test new exec code stuff
41ba092
@jdotjdot
try again
bf8f5e2
@jdotjdot
try writing to &3
fde7401
@jdotjdot
remove extra exit printing code
5d3c894
@jdotjdot
silence windows exit code test
32d12c5
@jdotjdot jdotjdot changed the title Add cronitor discover functionality for Windows Add Windows, update API version, update testing suite Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneharter shaneharter Awaiting requested review from shaneharter

@aflanagan aflanagan Awaiting requested review from aflanagan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdotjdot @shaneharter